Disco DeDisco 5a1acbd9ca
All checks were successful
ci/woodpecker/push/pyswiss Pipeline was successful
ci/woodpecker/push/main Pipeline was successful
CI test-FTs-room #334 fix — _seed_earthman_sig_pile missing is_polarized=True + has_card_images=False defaults (13 errors) + stale id_kit_fiorentine_deck selector → id_kit_tarot_deck (1 error). CI pipeline #334 test-FTs-room reported 1 FAIL + 13 errors after retry on a clean local-green branch; user asked for diagnosis. Two unrelated root causes — both pure FT-helper / FT-selector bugs surfaced by today's earlier landings (15025b4 my_sea single-stack collapse + f107522 RWS rename). No app code touched.
(1) **`_seed_earthman_sig_pile` helper missing two field defaults** — 13 errors + 1 FAIL across `MySeaCardDrawTest`. All 13 errors fail at `_draw_open_modal` line 716 looking for `.sea-deck-stack--levity`; the FAIL at `test_form_col_renders_decks_lock_hand_del_and_reversal_pct` asserts `len(stacks) == 2` and gets 1. Today's 15025b4 (A.7-polish my_sea single-stack collapse) added `{% if request.user.equipped_deck.is_polarized %}` branching to `my_sea.html:224`: polarized decks render `--gravity` + `--levity` stacks; non-polarized decks render a single `--single` stack. The `_seed_earthman_sig_pile()` helper at `functional_tests/sig_page.py` calls `DeckVariant.objects.get_or_create(slug="earthman", defaults={...})` w. only `name`, `card_count`, `is_default` in the defaults dict — `is_polarized` falls through to the model default of `False` (`epic/models.py:260`). Migration 0012 sets the field on the migration-seeded Earthman row via an explicit `.update(is_polarized=True, has_card_images=False, family="earthman")`, but `TransactionTestCase` flushes all tables on teardown (no `serialized_rollback` per [[feedback-transactiontestcase-flush]]) — once the first test method runs + tears down, the migration-seeded row is gone, and every subsequent test's setUp re-creates Earthman via the helper's incomplete defaults → `is_polarized=False` → my_sea picker renders single-stack → FT selector miss. Why local passed: `MySeaCardDrawTest` is class #5 of 6 in test_game_my_sea.py (setUps at lines 49, 208, 381, 474, 691, 1146); local runs typically scope to a single class or method (per [[feedback-ft-run-discipline]]), so the FIRST setUp finds the migration-seeded Earthman row still intact w. `is_polarized=True` and `get_or_create` returns it as-is. In CI's 152-test FT-room batch, four prior classes each truncate `epic_deckvariant` before class #5 runs, so the helper's defaults are all that's left. Fix: add `is_polarized=True, has_card_images=False` to the helper's defaults dict, mirroring migration 0012's explicit `.update()`. `family` stays implicit since the model default of `EARTHMAN` (`"earthman"`) already matches. Note: the parallel `_equip_earthman` helper in `test_game_room_deck_contrib.py:31-40` carries the same incomplete defaults but its tests don't depend on `is_polarized` — left untouched to avoid scope creep; would tighten consistency in a follow-up if the same trap bites again

(2) **Stale `#id_kit_fiorentine_deck` selector** — 1 error at `DeckInUseGameKitTest.test_non_contributing_deck_has_normal_don_doff`. f107522 (A.0 image-rendering schema + RWS rename) renamed the existing `fiorentine-minchiate` DeckVariant slug to `tarot-rider-waite-smith` (audit revealed the deck was actually 78-card RWS Tarot, not 97-card Minchiate). The kit panel template at `_applet-game-kit.html:87` derives the element id from `deck.short_key` (`epic/models.py:291`, first dash-separated word of slug) — so `tarot-rider-waite-smith` produces id `id_kit_tarot_deck`, not the old `id_kit_fiorentine_deck`. f107522's rename pass updated `test_game_room_deck_contrib.py`'s click target on line 194 (`#id_kit_tarot_deck`) but missed the immediately-following assertion's `wait_for` selector on line 198, leaving a mixed-slug FT that clicks the new id but waits for the old. Pure FT-selector swap

Tests: not run locally per [[feedback-ft-run-discipline]] — both fixes are FT-only (helper defaults + selector string); CI verification on next push will confirm the 14 reds go green. Files: `functional_tests/sig_page.py` (+1, -1) + `functional_tests/test_game_room_deck_contrib.py` (+1, -1)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-25 11:12:16 -04:00
feat: import Minchiate Fiorentine 1860-1890 deck assets (98 PNGs, alpha-channel transparent bg) + naming convention v2 + pngquant optimization tooling. Public-domain 1860-1890 lithograph scans sourced from Wikimedia (single download series + trump 11 Il Gobbo individually-sourced from same era series); user removed white backgrounds in Photoshop to leave irregular card-shape with transparent canvas. Filenames v2-conformant per [[reference-card-image-naming-convention]] (revised from v1 of 2026-05-24): deck slug carries -1860-1890 publication-year suffix so future Minchiate Fiorentine variants from different publishers/eras coexist cleanly; courts use rank-number-prefix (batons-11-page not batons-page) for linear sort key; trumps carry both numeric rank AND italian-name suffix (trumps-01-papa-uno, trumps-11-il-gobbo) for forensic identification across variant decks the user plans to sell. Il Matto (unnumbered Fool in Minchiate tradition) assigned rank 00 to give it a sortable position. Five trump filenames had elided-apostrophe slugs restored from the download source (-lacqua-l-acqua etc.). Card-back at <deck-slug>-back.png sorts alphabetically before all suit categories — no separate card-back/ subdir needed. pngquant 2.17.0 installed at C:\Users\adamc\AppData\Local\Programs\pngquant\, added to user PATH (effective next session) for future deck imports; ran with --quality=65-85 --speed=1 --strip --skip-if-larger for 57.6% size reduction (86.6 MB → 36.7 MB total, 935 KB → 383 KB avg). Second pass at --quality=40-65 hit pngquant's floor (only 0.5% further reduction — re-quantizing an already-quantized image has little headroom). Il Gobbo from Wikimedia was a dimensional outlier (1426x2366 vs siblings ~620x1024) — resized via System.Drawing HighQualityBicubic to 620x1029 before optimization. Format32bppArgb alpha channel verified intact across samples after optimization pass. Visually validated by user: cards must fill entire screen before any pixelization visible. Sprint A precursor — DeckVariant.has_card_images toggle + image-rendering template branch per [[project-image-based-deck-face-rendering]] follows in subsequent commits, will consume these assets in 6 surfaces (my_sign, my_sea, both billboard applets, room, game_kit). Asset set also unblocks downstream Sprint C+B [[project-deck-segment-model]] (admin form will require image upload + enforce naming convention) and Sprint D [[project-card-deck-icon]] (uses -back.png as the deck-stack icon's repeating card-face). Future: when Sprint B's admin form ships, wire pngquant into an optimize_card_images management command so admin uploads auto-optimize on save. Gitignore line src/apps/epic/static/apps/epic/images/cards-faces/minchiate-fiorentine/ dropped — v1 staging dir deleted (was only ever the rename-staging set; superseded by v2-named optimized set). Total disk delta: +36.7 MB binary content. No code changes — pure asset + convention import
2026-05-24 22:39:21 -04:00
2026-01-13 20:58:25 -05:00
Description
No description provided
155 MiB
Languages
Python 45%
JavaScript 37.6%
HTML 9%
SCSS 8.2%
Jinja 0.1%