my-sea spectate: live spread-sync + owner seat-ring push + visit caption fix — TDD
Three fixes to the my-sea spectator (bud-sea), all flowing over the existing `mysea_<owner>` spectate consumer: VISIT CAPTIONS (.sea-pos-label) — two bugs left every CROWN/COVER/… caption blank on my_sea_visit: - empty-hand: `label_by_position` was built from `latest_draw_slots`, which returns [] when the owner's hand is empty (only a significator placed) — so an owner mid-setup showed no captions, while her OWN my_sea (whose JS seeds labels from the POSITION_LABELS constant) showed them. Now the view pulls captions straight from POSITION_LABELS[spread], drawn-cards-independent. - `--seciUser` typo (used once, never defined) → invalid colour dropped → the labels inherited the body colour, contrasting on some palettes but blending into the felt on others (read as "missing"). → `--secUser`. SPREAD-SYNC — the owner's live draw pushed only the hand, not the spread, so a post-DEL spread switch landed the new cards into the OLD spread's cells (the asymmetry the user hit: owner on desire-obstacle-solution, visitor still laid out as escape-velocity). The spread now rides each `sea_draw` broadcast; `_applySpread` re-sets `data-spread` (CSS keys cell visibility off it), re-captions from a server-sourced POSITION_LABELS json_script, + clears stale fills before `_applyHand` repopulates against the right layout. OWNER-SIDE LIVE SEAT PUSH — the owner's my_sea now subscribes to her own spectate WS for `sea_seats`, so visitors arriving (deposit → 2C-6C) / leaving (BYE) appear without a refresh, same broadcast the spectators get. The visit page's inline `_renderSeats` is hoisted into my-sea-seats.js as the shared `mySeaRenderSeats(seats, myToken)` (+ `mySeaConnectSeatRing`); each page passes its own self-token (owner page passes '' — her 1C isn't --self server-side). Coverage: - ITs: MySeaVisitEmptyHandLabelsTest (captions present + rendered for an empty hand); MySeaLockHandViewTest broadcast test asserts the spread arg; spectate consumer test asserts the hand+spread relay (channels). - Jasmine: 6 new MySeaSeatsSpec cases for mySeaRenderSeats (per-seat rebuild, --self by token, owner-page no-self, no-duplicate re-render, one-shot flare). - Live-verified in Firefox: captions paint khaki on the brown palette; a desire-obstacle-solution sync flips data-spread + relabels Solution/Obstacle/ Desire + hides leave/cover/lay. [[feedback-jsonfield-exclude-sqlite-null]] not implicated; spread map is a plain dict lookup. 304 gameboard ITs + Jasmine green. Code architected by Disco DeDisco <discodedisco@outlook.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -66,7 +66,7 @@ class MySeaSpectateConsumerTest(TransactionTestCase):
|
||||
connected, _ = await comm.connect()
|
||||
self.assertFalse(connected)
|
||||
|
||||
async def test_present_invitee_receives_the_owners_hand(self):
|
||||
async def test_present_invitee_receives_the_owners_hand_and_spread(self):
|
||||
await database_sync_to_async(self._invite)(present=True)
|
||||
comm = self._comm(self.bud)
|
||||
connected, _ = await comm.connect()
|
||||
@@ -74,10 +74,16 @@ class MySeaSpectateConsumerTest(TransactionTestCase):
|
||||
from channels.layers import get_channel_layer
|
||||
hand = [{"position": "lay", "card_id": 1,
|
||||
"reversed": False, "polarity": "gravity"}]
|
||||
# The spread rides along so a spectator under a stale spread re-syncs its
|
||||
# cross layout/captions before filling the hand (asymmetry fix
|
||||
# 2026-05-30).
|
||||
await get_channel_layer().group_send(
|
||||
f"mysea_{self.owner.id}", {"type": "sea_draw", "hand": hand})
|
||||
f"mysea_{self.owner.id}",
|
||||
{"type": "sea_draw", "hand": hand, "spread": "escape-velocity"})
|
||||
msg = await comm.receive_json_from()
|
||||
self.assertEqual(msg, {"type": "sea_draw", "hand": hand})
|
||||
self.assertEqual(
|
||||
msg,
|
||||
{"type": "sea_draw", "hand": hand, "spread": "escape-velocity"})
|
||||
await comm.disconnect()
|
||||
|
||||
async def test_present_invitee_receives_seat_updates(self):
|
||||
|
||||
Reference in New Issue
Block a user