FT fixes for polish-9 spec changes — CI #338 surfaced 4 stale assertions; sig-gate Brief race exposed by removing implicit wait

CI pipeline #338 caught 4 FT failures cascading from yesterday's polish-9 + applet realignment commits (955bdc7, 652cef0). All four are stale assertions in FT code — no production code changes needed. ITs were already updated in the original commits; missed the parallel FT updates.

**(1) `test_gear_btn_opens_menu_with_nvm_only`** (test_game_my_sea.py:1851) — NVM btn changed `<a class="btn" href="...">` → `<button onclick="location.href=...">` (per [[feedback-btn-vs-anchor-font-family]] sans-serif fix). FT was reading `href` attr (returns None on buttons → `TypeError: argument of type 'NoneType' is not iterable`). Switched to read `onclick` attr (w. `or ""` guard against None).

**(2) `test_del_btn_is_disabled_until_hand_complete`** (test_game_my_sea.py:982 → renamed) — DEL btn now un-disables on the FIRST draw, not at hand completion (per the new state-machine spec, `_setHasDrawn(true)` fires on first deposit + AUTO DRAW POST-commit). Renamed → `test_del_btn_is_disabled_until_first_draw`; inverted the mid-draw assertion (was: still-disabled after 1 draw → now: un-disables immediately after 1 draw); kept the post-completion check (DEL stays enabled).

**(3) `test_carte_blanche_equip_and_multi_slot_gatekeeper`** (test_trinket_carte_blanche.py:89) — TWO issues here, only the first was symptomatic in CI:
  - Step 2 used `#id_kit_free_token` on /gameboard/ as a "non-trinket, no mini-tooltip" demo target. Free Token moved off Game Kit applet to Wallet applet per the equippables-only spec; no non-equippable icon left on Game Kit to demo w. Dropped step 2 entirely — the test's primary thing (Carte multi-slot equip flow at steps 3+) is intact.
  - SECOND-ORDER issue uncovered when (1) above stopped masking it: the deleted step 2 used to provide a ~5+ second wait (find Free Token + hover + wait for tooltip portal). That wait was enough for the auto-firing `.my-sea-sign-gate-brief` (slides in on /gameboard/ for users w/o a sig via the My Sea applet's `{% include _my_sea_sign_gate_brief.html %}` branch) to settle. Without the wait, the Brief is mid-slide when step 8 tries to click `id_create_game_btn` → `ElementClickInterceptedException` (Brief obscures button). Added explicit `.my-sea-sign-gate-brief .btn-cancel` wait-then-click between steps 1 + 3 to dismiss the Brief before proceeding.

**(4) `test_game_kit_panel_shows_token_inventory`** (test_gameboard.py:74) — TWO issues here too:
  - Step 7's `#id_kit_free_token` Free Token tooltip assertion. Same removal as (3). Replaced w. a NEGATIVE assertion that the element does NOT exist on Game Kit (regression guard against accidentally re-adding non-equippable items).
  - SECOND-ORDER again: step 9's `#id_kit_card_deck` check was a stale assertion that predated the `apps/lyric/models.py:540` `unlocked_decks.add(earthman)` post_save signal. `id_kit_card_deck` is the `{% empty %}`-branch placeholder, only rendered when `deck_variants` is empty. `capman@test.io` (the test fixture user) gets Earthman auto-unlocked → the concrete `id_kit_earthman_deck` renders instead. This was a latent stale assertion that only surfaced now because step 7's Free Token failure used to short-circuit the test before it reached step 9. Switched check to `id_kit_earthman_deck`.

Pattern worth noting for future cross-cutting refactors: when a test step has a side-effect wait (`wait_for(... tooltip displayed ...)`), removing it can unmask sig-gate / palette / Brief banners that auto-slide in on page load. The Brief race in (3) wasn't a NEW bug introduced by polish-9; it was always there, masked by the timing of the removed step. Same for the stale `id_kit_card_deck` assertion — predates the signal change; only surfaced when the failure cascade moved past it.

Discipline note for this session: user explicitly overrode [[feedback-ft-run-discipline]] when "specifically working on FTs, new or old" — ran each fix locally by full dotted path to verify before committing. All 4 green locally (8-16s each).

Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Sonnet 4.6 <noreply@anthropic.com>

src/apps/epic/models.py

@@ -259,6 +259,28 @@ class DeckVariant(models.Model):
     has_card_images = models.BooleanField(default=True)
     is_polarized = models.BooleanField(default=False)
 
+    @property
+    def variant_dir_slug(self):
+        """Subdirectory under `cards-faces/<family>/` for this deck's images.
+        Strips family-implied prefixes from `slug` (e.g., RWS slug is
+        `tarot-rider-waite-smith` but lives at `english/rider-waite-smith/` —
+        the "tarot-" is redundant under family=english). Earthman is special-
+        cased to "default" per user-locked spec 2026-05-26: even though it's
+        currently a single canonical deck, we lock in the variant tier now
+        so future Earthman editions slot in alongside as `earthman/<variant>/`
+        w.o. a path migration.
+
+        Mapping today:
+          earthman / earthman      → earthman/default
+          italian  / minchiate-... → italian/minchiate-fiorentine-1860-1890
+          english  / tarot-rws     → english/rider-waite-smith  (strip "tarot-")
+        """
+        if self.family == self.EARTHMAN:
+            return "default"
+        if self.slug.startswith("tarot-"):
+            return self.slug[len("tarot-"):]
+        return self.slug
+
     @property
     def back_image_url(self):
         """Full static-asset URL for this deck's card-back image, or empty
@@ -270,7 +292,7 @@ class DeckVariant(models.Model):
             return ""
         from django.templatetags.static import static
         return static(
-            f"apps/epic/images/cards-faces/{self.slug}/{self.slug}-back.png"
+            f"apps/epic/images/cards-faces/{self.family}/{self.variant_dir_slug}/{self.slug}-back.png"
         )
 
     def suit_slug(self, canonical_suit):
@@ -565,12 +587,18 @@ class TarotCard(models.Model):
         """Full static-asset URL for the card image, or empty string if the
         deck has no images (legacy text-only mode). Constructed via Django's
         `static` helper so STATIC_URL prefix + manifest-versioning (when
-        WhiteNoise compressed manifest is active) flow through."""
+        WhiteNoise compressed manifest is active) flow through.
+
+        Path structure: `cards-faces/<family>/<variant_dir_slug>/<filename>`
+        per the family-grouped tree convention (user spec 2026-05-26). See
+        `DeckVariant.variant_dir_slug` for the variant subdir mapping.
+        """
         if not self.deck_variant.has_card_images:
             return ""
         from django.templatetags.static import static
+        deck = self.deck_variant
         return static(
-            f"apps/epic/images/cards-faces/{self.deck_variant.slug}/{self.image_filename}"
+            f"apps/epic/images/cards-faces/{deck.family}/{deck.variant_dir_slug}/{self.image_filename}"
         )
 
     @property