new test_dashboard FT (part 1) for username applet on dashboard; apps/dashboard/home.html gained new applet section to support additions; new urlpatterns in apps.dash.urls; tweaks to .views, including the @login_required decorator and set_profile() FBV; new ITs in .tests.integrated.test_views

src/apps/dashboard/tests/integrated/test_views.py

@@ -241,7 +241,7 @@ class ViewAuthListTest(TestCase):
 
     def test_anonymous_user_is_redirected(self):
         response = self.client.get(reverse("view_list", args=[self.our_list.id]))
-        self.assertRedirects(response, "/")
+        self.assertRedirects(response, "/", fetch_redirect_response=False)
 
     def test_non_owner_non_shared_user_gets_403(self):
         stranger = User.objects.create(email="stranger@example.com")
@@ -308,3 +308,36 @@ class SetThemeTest(TestCase):
         parsed = lxml.html.fromstring(response.content)
         swatches = parsed.cssselect(".swatch")
         self.assertEqual(len(swatches), len(response.context["themes"]))
+
+class ProfileViewTest(TestCase):
+    def setUp(self):
+        self.user = User.objects.create(email="discoman@example.com")
+        self.client.force_login(self.user)
+
+    def test_post_username_saves_to_user(self):
+        self.client.post("/dashboard/set_profile", data={"username": "discoman"})
+        self.user.refresh_from_db()
+        self.assertEqual(self.user.username, "discoman")
+
+    def test_post_username_requires_login(self):
+        self.client.logout()
+        response = self.client.post("/dashboard/set_profile", data={"username": "somnambulist"})
+        self.assertRedirects(response, "/?next=/dashboard/set_profile")
+
+    def test_dash_renders_username_applet(self):
+        response = self.client.get("/")
+        parsed = lxml.html.fromstring(response.content)
+        [applet] = parsed.cssselect("#id_applet_username")
+        self.assertIn("di…an@e…e.com", applet.text_content())
+        [_] = parsed.cssselect("#id_new_username")
+
+    def test_dash_shows_display_name_in_applet(self):
+        self.user.username = "discoman"
+        self.user.save()
+        response = self.client.get("/")
+        parsed = lxml.html.fromstring(response.content)
+        [applet] = parsed.cssselect("#id_applet_username")
+        self.assertIn("discoman", applet.text_content())
+        [username_input] = parsed.cssselect("#id_new_username")
+        self.assertEqual("discoman", username_input.get("value"))
+

src/apps/dashboard/urls.py

@@ -4,7 +4,8 @@ from . import views
 urlpatterns = [
     path('new_list', views.new_list, name='new_list'),
     path('list/<uuid:list_id>/', views.view_list, name='view_list'),
-    path('users/<uuid:user_id>/', views.my_lists, name='my_lists'),
     path('list/<uuid:list_id>/share_list', views.share_list, name="share_list"),
     path('set_theme', views.set_theme, name='set_theme'),
+    path('set_profile', views.set_profile, name='set_profile'),
+    path('users/<uuid:user_id>/', views.my_lists, name='my_lists'),
 ]

src/apps/dashboard/views.py

@@ -1,4 +1,5 @@
 from django.contrib import messages
+from django.contrib.auth.decorators import login_required
 from django.http import HttpResponseForbidden
 from django.shortcuts import redirect, render
 
@@ -51,7 +52,7 @@ def view_list(request, list_id):
             form.save()
             return redirect(our_list)
     return render(request, "apps/dashboard/list.html", {"list": our_list, "form": form})
-            
+       
 def my_lists(request, user_id):
     owner = User.objects.get(id=user_id)
     if not request.user.is_authenticated:
@@ -72,12 +73,19 @@ def share_list(request, list_id):
     messages.success(request, "An invite has been sent if that address is registered.")
     return redirect(our_list)
 
+@login_required(login_url="/")
 def set_theme(request):
-    if not request.user.is_authenticated:
-        return redirect("home")
     if request.method == "POST":
         theme = request.POST.get("theme", "")
         if theme in UNLOCKED_THEMES:
             request.user.theme = theme
             request.user.save(update_fields=["theme"])
     return redirect("home")
+
+@login_required(login_url="/")
+def set_profile(request):
+    if request.method == "POST":
+        username = request.POST.get("username", "")
+        request.user.username = username
+        request.user.save(update_fields=["username"])
+    return redirect("/")