renamed List to Note everywhere thru-out project in preparation for complete overhaul of applet capabilities
This commit is contained in:
@@ -2,8 +2,8 @@ from django import forms
|
||||
from django.core.exceptions import ValidationError
|
||||
from .models import Item
|
||||
|
||||
DUPLICATE_ITEM_ERROR = "You've already logged this to your list"
|
||||
EMPTY_ITEM_ERROR = "You can't have an empty list item"
|
||||
DUPLICATE_ITEM_ERROR = "You've already logged this to your note"
|
||||
EMPTY_ITEM_ERROR = "You can't have an empty note item"
|
||||
|
||||
class ItemForm(forms.Form):
|
||||
text = forms.CharField(
|
||||
@@ -11,22 +11,22 @@ class ItemForm(forms.Form):
|
||||
required=True,
|
||||
)
|
||||
|
||||
def save(self, for_list):
|
||||
def save(self, for_note):
|
||||
return Item.objects.create(
|
||||
list=for_list,
|
||||
note=for_note,
|
||||
text=self.cleaned_data["text"],
|
||||
)
|
||||
|
||||
class ExistingListItemForm(ItemForm):
|
||||
def __init__(self, for_list, *args, **kwargs):
|
||||
class ExistingNoteItemForm(ItemForm):
|
||||
def __init__(self, for_note, *args, **kwargs):
|
||||
super().__init__(*args, **kwargs)
|
||||
self._for_list = for_list
|
||||
self._for_note = for_note
|
||||
|
||||
def clean_text(self):
|
||||
text = self.cleaned_data["text"]
|
||||
if self._for_list.item_set.filter(text=text).exists():
|
||||
if self._for_note.item_set.filter(text=text).exists():
|
||||
raise forms.ValidationError(DUPLICATE_ITEM_ERROR)
|
||||
return text
|
||||
|
||||
|
||||
def save(self):
|
||||
return super().save(for_list=self._for_list)
|
||||
return super().save(for_note=self._for_note)
|
||||
|
||||
20
src/apps/dashboard/migrations/0002_rename_list_to_note.py
Normal file
20
src/apps/dashboard/migrations/0002_rename_list_to_note.py
Normal file
@@ -0,0 +1,20 @@
|
||||
from django.db import migrations
|
||||
|
||||
|
||||
class Migration(migrations.Migration):
|
||||
|
||||
dependencies = [
|
||||
('dashboard', '0001_initial'),
|
||||
]
|
||||
|
||||
operations = [
|
||||
migrations.RenameModel(
|
||||
old_name='List',
|
||||
new_name='Note',
|
||||
),
|
||||
migrations.RenameField(
|
||||
model_name='Item',
|
||||
old_name='list',
|
||||
new_name='note',
|
||||
),
|
||||
]
|
||||
@@ -4,11 +4,11 @@ from django.db import models
|
||||
from django.urls import reverse
|
||||
|
||||
|
||||
class List(models.Model):
|
||||
class Note(models.Model):
|
||||
id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
|
||||
owner = models.ForeignKey(
|
||||
"lyric.User",
|
||||
related_name="lists",
|
||||
related_name="notes",
|
||||
blank=True,
|
||||
null=True,
|
||||
on_delete=models.CASCADE,
|
||||
@@ -16,7 +16,7 @@ class List(models.Model):
|
||||
|
||||
shared_with = models.ManyToManyField(
|
||||
"lyric.User",
|
||||
related_name="shared_lists",
|
||||
related_name="shared_notes",
|
||||
blank=True,
|
||||
)
|
||||
|
||||
@@ -25,15 +25,15 @@ class List(models.Model):
|
||||
return self.item_set.first().text
|
||||
|
||||
def get_absolute_url(self):
|
||||
return reverse("view_list", args=[self.id])
|
||||
return reverse("view_note", args=[self.id])
|
||||
|
||||
class Item(models.Model):
|
||||
text = models.TextField(default="")
|
||||
list = models.ForeignKey(List, default=None, on_delete=models.CASCADE)
|
||||
note = models.ForeignKey(Note, default=None, on_delete=models.CASCADE)
|
||||
|
||||
class Meta:
|
||||
ordering = ("id",)
|
||||
unique_together = ("list", "text")
|
||||
unique_together = ("note", "text")
|
||||
|
||||
def __str__(self):
|
||||
return self.text
|
||||
return self.text
|
||||
|
||||
@@ -3,39 +3,39 @@ from django.test import TestCase
|
||||
from apps.dashboard.forms import (
|
||||
DUPLICATE_ITEM_ERROR,
|
||||
EMPTY_ITEM_ERROR,
|
||||
ExistingListItemForm,
|
||||
ExistingNoteItemForm,
|
||||
ItemForm,
|
||||
)
|
||||
from apps.dashboard.models import Item, List
|
||||
from apps.dashboard.models import Item, Note
|
||||
|
||||
|
||||
class ItemFormTest(TestCase):
|
||||
def test_form_save_handles_saving_to_a_list(self):
|
||||
mylist = List.objects.create()
|
||||
def test_form_save_handles_saving_to_a_note(self):
|
||||
mynote = Note.objects.create()
|
||||
form = ItemForm(data={"text": "do re mi"})
|
||||
self.assertTrue(form.is_valid())
|
||||
new_item = form.save(for_list=mylist)
|
||||
new_item = form.save(for_note=mynote)
|
||||
self.assertEqual(new_item, Item.objects.get())
|
||||
self.assertEqual(new_item.text, "do re mi")
|
||||
self.assertEqual(new_item.list, mylist)
|
||||
self.assertEqual(new_item.note, mynote)
|
||||
|
||||
class ExistingListItemFormTest(TestCase):
|
||||
class ExistingNoteItemFormTest(TestCase):
|
||||
def test_form_validation_for_blank_items(self):
|
||||
list_ = List.objects.create()
|
||||
form = ExistingListItemForm(for_list=list_, data={"text": ""})
|
||||
note = Note.objects.create()
|
||||
form = ExistingNoteItemForm(for_note=note, data={"text": ""})
|
||||
self.assertFalse(form.is_valid())
|
||||
self.assertEqual(form.errors["text"], [EMPTY_ITEM_ERROR])
|
||||
|
||||
def test_form_validation_for_duplicate_items(self):
|
||||
list_ = List.objects.create()
|
||||
Item.objects.create(list=list_, text="twins, basil")
|
||||
form = ExistingListItemForm(for_list=list_, data={"text": "twins, basil"})
|
||||
note = Note.objects.create()
|
||||
Item.objects.create(note=note, text="twins, basil")
|
||||
form = ExistingNoteItemForm(for_note=note, data={"text": "twins, basil"})
|
||||
self.assertFalse(form.is_valid())
|
||||
self.assertEqual(form.errors["text"], [DUPLICATE_ITEM_ERROR])
|
||||
|
||||
def test_form_save(self):
|
||||
mylist = List.objects.create()
|
||||
form = ExistingListItemForm(for_list=mylist, data={"text": "howdy"})
|
||||
mynote = Note.objects.create()
|
||||
form = ExistingNoteItemForm(for_note=mynote, data={"text": "howdy"})
|
||||
self.assertTrue(form.is_valid())
|
||||
new_item = form.save()
|
||||
self.assertEqual(new_item, Item.objects.get())
|
||||
|
||||
@@ -2,69 +2,69 @@ from django.core.exceptions import ValidationError
|
||||
from django.db.utils import IntegrityError
|
||||
from django.test import TestCase
|
||||
|
||||
from apps.dashboard.models import Item, List
|
||||
from apps.dashboard.models import Item, Note
|
||||
from apps.lyric.models import User
|
||||
|
||||
|
||||
class ItemModelTest(TestCase):
|
||||
def test_item_is_related_to_list(self):
|
||||
mylist = List.objects.create()
|
||||
def test_item_is_related_to_note(self):
|
||||
mynote = Note.objects.create()
|
||||
item = Item()
|
||||
item.list = mylist
|
||||
item.note = mynote
|
||||
item.save()
|
||||
self.assertIn(item, mylist.item_set.all())
|
||||
self.assertIn(item, mynote.item_set.all())
|
||||
|
||||
def test_cannot_save_null_list_items(self):
|
||||
mylist = List.objects.create()
|
||||
item = Item(list=mylist, text=None)
|
||||
def test_cannot_save_null_note_items(self):
|
||||
mynote = Note.objects.create()
|
||||
item = Item(note=mynote, text=None)
|
||||
with self.assertRaises(IntegrityError):
|
||||
item.save()
|
||||
|
||||
def test_cannot_save_empty_list_items(self):
|
||||
mylist = List.objects.create()
|
||||
item = Item(list=mylist, text="")
|
||||
def test_cannot_save_empty_note_items(self):
|
||||
mynote = Note.objects.create()
|
||||
item = Item(note=mynote, text="")
|
||||
with self.assertRaises(ValidationError):
|
||||
item.full_clean()
|
||||
|
||||
def test_duplicate_items_are_invalid(self):
|
||||
mylist = List.objects.create()
|
||||
Item.objects.create(list=mylist, text="jklol")
|
||||
mynote = Note.objects.create()
|
||||
Item.objects.create(note=mynote, text="jklol")
|
||||
with self.assertRaises(ValidationError):
|
||||
item = Item(list=mylist, text="jklol")
|
||||
item = Item(note=mynote, text="jklol")
|
||||
item.full_clean()
|
||||
|
||||
def test_still_can_save_same_item_to_different_lists(self):
|
||||
list1 = List.objects.create()
|
||||
list2 = List.objects.create()
|
||||
Item.objects.create(list=list1, text="nojk")
|
||||
item = Item(list=list2, text="nojk")
|
||||
def test_still_can_save_same_item_to_different_notes(self):
|
||||
note1 = Note.objects.create()
|
||||
note2 = Note.objects.create()
|
||||
Item.objects.create(note=note1, text="nojk")
|
||||
item = Item(note=note2, text="nojk")
|
||||
item.full_clean() # should not raise
|
||||
|
||||
class ListModelTest(TestCase):
|
||||
class NoteModelTest(TestCase):
|
||||
def test_get_absolute_url(self):
|
||||
mylist = List.objects.create()
|
||||
self.assertEqual(mylist.get_absolute_url(), f"/dashboard/list/{mylist.id}/")
|
||||
mynote = Note.objects.create()
|
||||
self.assertEqual(mynote.get_absolute_url(), f"/dashboard/note/{mynote.id}/")
|
||||
|
||||
def test_list_items_order(self):
|
||||
list1 = List.objects.create()
|
||||
item1 = Item.objects.create(list=list1, text="i1")
|
||||
item2 = Item.objects.create(list=list1, text="item 2")
|
||||
item3 = Item.objects.create(list=list1, text="3")
|
||||
def test_note_items_order(self):
|
||||
note1 = Note.objects.create()
|
||||
item1 = Item.objects.create(note=note1, text="i1")
|
||||
item2 = Item.objects.create(note=note1, text="item 2")
|
||||
item3 = Item.objects.create(note=note1, text="3")
|
||||
self.assertEqual(
|
||||
list(list1.item_set.all()),
|
||||
list(note1.item_set.all()),
|
||||
[item1, item2, item3],
|
||||
)
|
||||
|
||||
def test_lists_can_have_owners(self):
|
||||
def test_notes_can_have_owners(self):
|
||||
user = User.objects.create(email="a@b.cde")
|
||||
mylist = List.objects.create(owner=user)
|
||||
self.assertIn(mylist, user.lists.all())
|
||||
mynote = Note.objects.create(owner=user)
|
||||
self.assertIn(mynote, user.notes.all())
|
||||
|
||||
def test_list_owner_is_optional(self):
|
||||
List.objects.create()
|
||||
def test_note_owner_is_optional(self):
|
||||
Note.objects.create()
|
||||
|
||||
def test_list_name_is_first_item_text(self):
|
||||
list_ = List.objects.create()
|
||||
Item.objects.create(list=list_, text="first item")
|
||||
Item.objects.create(list=list_, text="second item")
|
||||
self.assertEqual(list_.name, "first item")
|
||||
def test_note_name_is_first_item_text(self):
|
||||
note = Note.objects.create()
|
||||
Item.objects.create(note=note, text="first item")
|
||||
Item.objects.create(note=note, text="second item")
|
||||
self.assertEqual(note.name, "first item")
|
||||
|
||||
@@ -10,7 +10,7 @@ from apps.dashboard.forms import (
|
||||
DUPLICATE_ITEM_ERROR,
|
||||
EMPTY_ITEM_ERROR,
|
||||
)
|
||||
from apps.dashboard.models import Item, List
|
||||
from apps.dashboard.models import Item, Note
|
||||
from apps.lyric.models import User
|
||||
|
||||
|
||||
@@ -18,7 +18,7 @@ class HomePageTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="disco@test.io")
|
||||
self.client.force_login(self.user)
|
||||
Applet.objects.get_or_create(slug="new-list", defaults={"name": "New List"})
|
||||
Applet.objects.get_or_create(slug="new-note", defaults={"name": "New Note"})
|
||||
|
||||
def test_uses_home_template(self):
|
||||
response = self.client.get('/')
|
||||
@@ -28,36 +28,36 @@ class HomePageTest(TestCase):
|
||||
response = self.client.get('/')
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
forms = parsed.cssselect('form[method=POST]')
|
||||
self.assertIn("/dashboard/new_list", [form.get("action") for form in forms])
|
||||
[form] = [form for form in forms if form.get("action") == "/dashboard/new_list"]
|
||||
self.assertIn("/dashboard/new_note", [form.get("action") for form in forms])
|
||||
[form] = [form for form in forms if form.get("action") == "/dashboard/new_note"]
|
||||
inputs = form.cssselect("input")
|
||||
self.assertIn("text", [input.get("name") for input in inputs])
|
||||
|
||||
class NewListTest(TestCase):
|
||||
class NewNoteTest(TestCase):
|
||||
def setUp(self):
|
||||
user = User.objects.create(email="disco@test.io")
|
||||
self.client.force_login(user)
|
||||
|
||||
def test_can_save_a_POST_request(self):
|
||||
self.client.post("/dashboard/new_list", data={"text": "A new list item"})
|
||||
self.client.post("/dashboard/new_note", data={"text": "A new note item"})
|
||||
self.assertEqual(Item.objects.count(), 1)
|
||||
new_item = Item.objects.get()
|
||||
self.assertEqual(new_item.text, "A new list item")
|
||||
self.assertEqual(new_item.text, "A new note item")
|
||||
|
||||
def test_redirects_after_POST(self):
|
||||
response = self.client.post("/dashboard/new_list", data={"text": "A new list item"})
|
||||
new_list = List.objects.get()
|
||||
self.assertRedirects(response, f"/dashboard/list/{new_list.id}/")
|
||||
response = self.client.post("/dashboard/new_note", data={"text": "A new note item"})
|
||||
new_note = Note.objects.get()
|
||||
self.assertRedirects(response, f"/dashboard/note/{new_note.id}/")
|
||||
|
||||
# Post invalid input helper
|
||||
def post_invalid_input(self):
|
||||
return self.client.post("/dashboard/new_list", data={"text": ""})
|
||||
return self.client.post("/dashboard/new_note", data={"text": ""})
|
||||
|
||||
def test_for_invalid_input_nothing_saved_to_db(self):
|
||||
self.post_invalid_input()
|
||||
self.assertEqual(Item.objects.count(), 0)
|
||||
|
||||
def test_for_invalid_input_renders_list_template(self):
|
||||
def test_for_invalid_input_renders_home_template(self):
|
||||
response = self.post_invalid_input()
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertTemplateUsed(response, "apps/dashboard/home.html")
|
||||
@@ -67,15 +67,15 @@ class NewListTest(TestCase):
|
||||
self.assertContains(response, html.escape(EMPTY_ITEM_ERROR))
|
||||
|
||||
@override_settings(COMPRESS_ENABLED=False)
|
||||
class ListViewTest(TestCase):
|
||||
def test_uses_list_template(self):
|
||||
mylist = List.objects.create()
|
||||
response = self.client.get(f"/dashboard/list/{mylist.id}/")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/list.html")
|
||||
class NoteViewTest(TestCase):
|
||||
def test_uses_note_template(self):
|
||||
mynote = Note.objects.create()
|
||||
response = self.client.get(f"/dashboard/note/{mynote.id}/")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/note.html")
|
||||
|
||||
def test_renders_input_form(self):
|
||||
mylist = List.objects.create()
|
||||
url = f"/dashboard/list/{mylist.id}/"
|
||||
mynote = Note.objects.create()
|
||||
url = f"/dashboard/note/{mynote.id}/"
|
||||
response = self.client.get(url)
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
forms = parsed.cssselect("form[method=POST]")
|
||||
@@ -84,58 +84,58 @@ class ListViewTest(TestCase):
|
||||
inputs = form.cssselect("input")
|
||||
self.assertIn("text", [input.get("name") for input in inputs])
|
||||
|
||||
def test_displays_only_items_for_that_list(self):
|
||||
def test_displays_only_items_for_that_note(self):
|
||||
# Given/Arrange
|
||||
correct_list = List.objects.create()
|
||||
Item.objects.create(text="itemey 1", list=correct_list)
|
||||
Item.objects.create(text="itemey 2", list=correct_list)
|
||||
other_list = List.objects.create()
|
||||
Item.objects.create(text="other list item", list=other_list)
|
||||
correct_note = Note.objects.create()
|
||||
Item.objects.create(text="itemey 1", note=correct_note)
|
||||
Item.objects.create(text="itemey 2", note=correct_note)
|
||||
other_note = Note.objects.create()
|
||||
Item.objects.create(text="other note item", note=other_note)
|
||||
# When/Act
|
||||
response = self.client.get(f"/dashboard/list/{correct_list.id}/")
|
||||
response = self.client.get(f"/dashboard/note/{correct_note.id}/")
|
||||
# Then/Assert
|
||||
self.assertContains(response, "itemey 1")
|
||||
self.assertContains(response, "itemey 2")
|
||||
self.assertNotContains(response, "other list item")
|
||||
self.assertNotContains(response, "other note item")
|
||||
|
||||
def test_can_save_a_POST_request_to_an_existing_list(self):
|
||||
other_list = List.objects.create()
|
||||
correct_list = List.objects.create()
|
||||
def test_can_save_a_POST_request_to_an_existing_note(self):
|
||||
other_note = Note.objects.create()
|
||||
correct_note = Note.objects.create()
|
||||
|
||||
self.client.post(
|
||||
f"/dashboard/list/{correct_list.id}/",
|
||||
data={"text": "A new item for an existing list"},
|
||||
f"/dashboard/note/{correct_note.id}/",
|
||||
data={"text": "A new item for an existing note"},
|
||||
)
|
||||
|
||||
self.assertEqual(Item.objects.count(), 1)
|
||||
new_item = Item.objects.get()
|
||||
self.assertEqual(new_item.text, "A new item for an existing list")
|
||||
self.assertEqual(new_item.list, correct_list)
|
||||
self.assertEqual(new_item.text, "A new item for an existing note")
|
||||
self.assertEqual(new_item.note, correct_note)
|
||||
|
||||
def test_POST_redirects_to_list_view(self):
|
||||
other_list = List.objects.create()
|
||||
correct_list = List.objects.create()
|
||||
def test_POST_redirects_to_note_view(self):
|
||||
other_note = Note.objects.create()
|
||||
correct_note = Note.objects.create()
|
||||
|
||||
response = self.client.post(
|
||||
f"/dashboard/list/{correct_list.id}/",
|
||||
data={"text": "A new item for an existing list"},
|
||||
f"/dashboard/note/{correct_note.id}/",
|
||||
data={"text": "A new item for an existing note"},
|
||||
)
|
||||
|
||||
self.assertRedirects(response, f"/dashboard/list/{correct_list.id}/")
|
||||
self.assertRedirects(response, f"/dashboard/note/{correct_note.id}/")
|
||||
|
||||
# Post invalid input helper
|
||||
def post_invalid_input(self):
|
||||
mylist = List.objects.create()
|
||||
return self.client.post(f"/dashboard/list/{mylist.id}/", data={"text": ""})
|
||||
mynote = Note.objects.create()
|
||||
return self.client.post(f"/dashboard/note/{mynote.id}/", data={"text": ""})
|
||||
|
||||
def test_for_invalid_input_nothing_saved_to_db(self):
|
||||
self.post_invalid_input()
|
||||
self.assertEqual(Item.objects.count(), 0)
|
||||
|
||||
def test_for_invalid_input_renders_list_template(self):
|
||||
def test_for_invalid_input_renders_note_template(self):
|
||||
response = self.post_invalid_input()
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertTemplateUsed(response, "apps/dashboard/list.html")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/note.html")
|
||||
|
||||
def test_for_invalid_input_shows_error_on_page(self):
|
||||
response = self.post_invalid_input()
|
||||
@@ -147,26 +147,26 @@ class ListViewTest(TestCase):
|
||||
[input] = parsed.cssselect("input[name=text]")
|
||||
self.assertIn("is-invalid", set(input.classes))
|
||||
|
||||
def test_duplicate_item_validation_errors_end_up_on_lists_page(self):
|
||||
list1 = List.objects.create()
|
||||
Item.objects.create(list=list1, text="lorem ipsum")
|
||||
def test_duplicate_item_validation_errors_end_up_on_note_page(self):
|
||||
note1 = Note.objects.create()
|
||||
Item.objects.create(note=note1, text="lorem ipsum")
|
||||
|
||||
response = self.client.post(
|
||||
f"/dashboard/list/{list1.id}/",
|
||||
f"/dashboard/note/{note1.id}/",
|
||||
data={"text": "lorem ipsum"},
|
||||
)
|
||||
|
||||
expected_error = html.escape(DUPLICATE_ITEM_ERROR)
|
||||
self.assertContains(response, expected_error)
|
||||
self.assertTemplateUsed(response, "apps/dashboard/list.html")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/note.html")
|
||||
self.assertEqual(Item.objects.all().count(), 1)
|
||||
|
||||
class MyListsTest(TestCase):
|
||||
def test_my_lists_url_renders_my_lists_template(self):
|
||||
class MyNotesTest(TestCase):
|
||||
def test_my_notes_url_renders_my_notes_template(self):
|
||||
user = User.objects.create(email="a@b.cde")
|
||||
self.client.force_login(user)
|
||||
response = self.client.get(f"/dashboard/users/{user.id}/")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/my_lists.html")
|
||||
self.assertTemplateUsed(response, "apps/dashboard/my_notes.html")
|
||||
|
||||
def test_passes_correct_owner_to_template(self):
|
||||
User.objects.create(email="wrongowner@example.com")
|
||||
@@ -175,20 +175,20 @@ class MyListsTest(TestCase):
|
||||
response = self.client.get(f"/dashboard/users/{correct_user.id}/")
|
||||
self.assertEqual(response.context["owner"], correct_user)
|
||||
|
||||
def test_list_owner_is_saved_if_user_is_authenticated(self):
|
||||
def test_note_owner_is_saved_if_user_is_authenticated(self):
|
||||
user = User.objects.create(email="a@b.cde")
|
||||
self.client.force_login(user)
|
||||
self.client.post("/dashboard/new_list", data={"text": "new item"})
|
||||
new_list = List.objects.get()
|
||||
self.assertEqual(new_list.owner, user)
|
||||
self.client.post("/dashboard/new_note", data={"text": "new item"})
|
||||
new_note = Note.objects.get()
|
||||
self.assertEqual(new_note.owner, user)
|
||||
|
||||
def test_my_lists_redirects_if_not_logged_in(self):
|
||||
def test_my_notes_redirects_if_not_logged_in(self):
|
||||
user = User.objects.create(email="a@b.cde")
|
||||
response = self.client.get(f"/dashboard/users/{user.id}/")
|
||||
self.assertRedirects(response, "/")
|
||||
|
||||
def test_my_lists_returns_403_for_wrong_user(self):
|
||||
# create two users, login as user_a, request user_b's my_lists url
|
||||
def test_my_notes_returns_403_for_wrong_user(self):
|
||||
# create two users, login as user_a, request user_b's my_notes url
|
||||
user1 = User.objects.create(email="a@b.cde")
|
||||
user2 = User.objects.create(email="wrongowner@example.com")
|
||||
self.client.force_login(user2)
|
||||
@@ -196,50 +196,50 @@ class MyListsTest(TestCase):
|
||||
# assert 403
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
class ShareListTest(TestCase):
|
||||
def test_post_to_share_list_url_redirects_to_list(self):
|
||||
our_list = List.objects.create()
|
||||
class ShareNoteTest(TestCase):
|
||||
def test_post_to_share_note_url_redirects_to_note(self):
|
||||
our_note = Note.objects.create()
|
||||
alice = User.objects.create(email="alice@example.com")
|
||||
response = self.client.post(
|
||||
f"/dashboard/list/{our_list.id}/share_list",
|
||||
f"/dashboard/note/{our_note.id}/share_note",
|
||||
data={"recipient": "alice@example.com"},
|
||||
)
|
||||
self.assertRedirects(response, f"/dashboard/list/{our_list.id}/")
|
||||
self.assertRedirects(response, f"/dashboard/note/{our_note.id}/")
|
||||
|
||||
def test_post_with_email_adds_user_to_shared_with(self):
|
||||
our_list = List.objects.create()
|
||||
our_note = Note.objects.create()
|
||||
alice = User.objects.create(email="alice@example.com")
|
||||
self.client.post(
|
||||
f"/dashboard/list/{our_list.id}/share_list",
|
||||
f"/dashboard/note/{our_note.id}/share_note",
|
||||
data={"recipient": "alice@example.com"},
|
||||
)
|
||||
self.assertIn(alice, our_list.shared_with.all())
|
||||
self.assertIn(alice, our_note.shared_with.all())
|
||||
|
||||
def test_post_with_nonexistent_email_redirects_to_list(self):
|
||||
our_list = List.objects.create()
|
||||
def test_post_with_nonexistent_email_redirects_to_note(self):
|
||||
our_note = Note.objects.create()
|
||||
response = self.client.post(
|
||||
f"/dashboard/list/{our_list.id}/share_list",
|
||||
f"/dashboard/note/{our_note.id}/share_note",
|
||||
data={"recipient": "nobody@example.com"},
|
||||
)
|
||||
self.assertRedirects(
|
||||
response,
|
||||
f"/dashboard/list/{our_list.id}/",
|
||||
f"/dashboard/note/{our_note.id}/",
|
||||
fetch_redirect_response=False,
|
||||
)
|
||||
|
||||
def test_share_list_does_not_add_owner_as_recipient(self):
|
||||
def test_share_note_does_not_add_owner_as_recipient(self):
|
||||
owner = User.objects.create(email="owner@example.com")
|
||||
our_list = List.objects.create(owner=owner)
|
||||
our_note = Note.objects.create(owner=owner)
|
||||
self.client.force_login(owner)
|
||||
self.client.post(reverse("share_list", args=[our_list.id]),
|
||||
self.client.post(reverse("share_note", args=[our_note.id]),
|
||||
data={"recipient": "owner@example.com"})
|
||||
self.assertNotIn(owner, our_list.shared_with.all())
|
||||
self.assertNotIn(owner, our_note.shared_with.all())
|
||||
|
||||
@override_settings(MESSAGE_STORAGE='django.contrib.messages.storage.session.SessionStorage')
|
||||
def test_share_list_shows_privacy_safe_message(self):
|
||||
our_list = List.objects.create()
|
||||
def test_share_note_shows_privacy_safe_message(self):
|
||||
our_note = Note.objects.create()
|
||||
response = self.client.post(
|
||||
f"/dashboard/list/{our_list.id}/share_list",
|
||||
f"/dashboard/note/{our_note.id}/share_note",
|
||||
data={"recipient": "nobody@example.com"},
|
||||
follow=True,
|
||||
)
|
||||
@@ -249,26 +249,26 @@ class ShareListTest(TestCase):
|
||||
"An invite has been sent if that address is registered.",
|
||||
)
|
||||
|
||||
class ViewAuthListTest(TestCase):
|
||||
class ViewAuthNoteTest(TestCase):
|
||||
def setUp(self):
|
||||
self.owner = User.objects.create(email="disco@example.com")
|
||||
self.our_list = List.objects.create(owner=self.owner)
|
||||
self.our_note = Note.objects.create(owner=self.owner)
|
||||
|
||||
def test_anonymous_user_is_redirected(self):
|
||||
response = self.client.get(reverse("view_list", args=[self.our_list.id]))
|
||||
response = self.client.get(reverse("view_note", args=[self.our_note.id]))
|
||||
self.assertRedirects(response, "/", fetch_redirect_response=False)
|
||||
|
||||
def test_non_owner_non_shared_user_gets_403(self):
|
||||
stranger = User.objects.create(email="stranger@example.com")
|
||||
self.client.force_login(stranger)
|
||||
response = self.client.get(reverse("view_list", args=[self.our_list.id]))
|
||||
response = self.client.get(reverse("view_note", args=[self.our_note.id]))
|
||||
self.assertEqual(response.status_code, 403)
|
||||
|
||||
def test_shared_with_user_can_access_list(self):
|
||||
def test_shared_with_user_can_access_note(self):
|
||||
guest = User.objects.create(email="guest@example.com")
|
||||
self.our_list.shared_with.add(guest)
|
||||
self.our_note.shared_with.add(guest)
|
||||
self.client.force_login(guest)
|
||||
response = self.client.get(reverse("view_list", args=[self.our_list.id]))
|
||||
response = self.client.get(reverse("view_note", args=[self.our_note.id]))
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
@override_settings(COMPRESS_ENABLED=False)
|
||||
@@ -278,7 +278,7 @@ class SetPaletteTest(TestCase):
|
||||
self.client.force_login(self.user)
|
||||
self.url = reverse("home")
|
||||
Applet.objects.get_or_create(slug="palette", defaults={"name": "Palette"})
|
||||
|
||||
|
||||
def test_anonymous_user_is_redirected_home(self):
|
||||
response = self.client.post("/dashboard/set_palette")
|
||||
self.assertRedirects(response, "/", fetch_redirect_response=False)
|
||||
@@ -299,7 +299,7 @@ class SetPaletteTest(TestCase):
|
||||
response = self.client.post("/dashboard/set_palette", data={"palette": "palette-default"})
|
||||
self.assertRedirects(response, "/", fetch_redirect_response=False)
|
||||
|
||||
def test_my_lists_contains_set_palette_form(self):
|
||||
def test_dashboard_contains_set_palette_form(self):
|
||||
response = self.client.get(self.url)
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
forms = parsed.cssselect('form[action="/dashboard/set_palette"]')
|
||||
@@ -434,7 +434,7 @@ class FooterNavTest(TestCase):
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
[nav] = parsed.cssselect("#id_footer_nav")
|
||||
self.assertIsNotNone(nav)
|
||||
|
||||
|
||||
def test_footer_nav_has_dashboard_link(self):
|
||||
response = self.client.get("/")
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
@@ -447,7 +447,7 @@ class FooterNavTest(TestCase):
|
||||
parsed = lxml.html.fromstring(response.content)
|
||||
[nav] = parsed.cssselect("#id_footer_nav")
|
||||
links = [a.get("href") for a in nav.cssselect("a")]
|
||||
self.assertIn("/gameboard/", links)
|
||||
self.assertIn("/gameboard/", links)
|
||||
|
||||
class WalletAppletTest(TestCase):
|
||||
def setUp(self):
|
||||
|
||||
@@ -2,12 +2,12 @@ from django.urls import path
|
||||
from . import views
|
||||
|
||||
urlpatterns = [
|
||||
path('new_list', views.new_list, name='new_list'),
|
||||
path('list/<uuid:list_id>/', views.view_list, name='view_list'),
|
||||
path('list/<uuid:list_id>/share_list', views.share_list, name="share_list"),
|
||||
path('new_note', views.new_note, name='new_note'),
|
||||
path('note/<uuid:note_id>/', views.view_note, name='view_note'),
|
||||
path('note/<uuid:note_id>/share_note', views.share_note, name="share_note"),
|
||||
path('set_palette', views.set_palette, name='set_palette'),
|
||||
path('set_profile', views.set_profile, name='set_profile'),
|
||||
path('users/<uuid:user_id>/', views.my_lists, name='my_lists'),
|
||||
path('users/<uuid:user_id>/', views.my_notes, name='my_notes'),
|
||||
path('toggle_applets', views.toggle_applets, name="toggle_applets"),
|
||||
path('wallet/', views.wallet, name='wallet'),
|
||||
path('wallet/toggle-applets', views.toggle_wallet_applets, name='toggle_wallet_applets'),
|
||||
|
||||
@@ -10,12 +10,12 @@ from django.views.decorators.csrf import ensure_csrf_cookie
|
||||
|
||||
from apps.applets.models import Applet, UserApplet
|
||||
from apps.applets.utils import applet_context
|
||||
from apps.dashboard.forms import ExistingListItemForm, ItemForm
|
||||
from apps.dashboard.models import Item, List
|
||||
from apps.dashboard.forms import ExistingNoteItemForm, ItemForm
|
||||
from apps.dashboard.models import Item, Note
|
||||
from apps.lyric.models import PaymentMethod, Token, User, Wallet
|
||||
|
||||
|
||||
APPLET_ORDER = ["wallet", "new-list", "my-lists", "username", "palette"]
|
||||
APPLET_ORDER = ["wallet", "new-note", "my-notes", "username", "palette"]
|
||||
UNLOCKED_PALETTES = frozenset(["palette-default"])
|
||||
PALETTES = [
|
||||
{"name": "palette-default", "label": "Earthman", "locked": False},
|
||||
@@ -27,9 +27,9 @@ PALETTES = [
|
||||
]
|
||||
|
||||
|
||||
def _recent_lists(user, limit=3):
|
||||
def _recent_notes(user, limit=3):
|
||||
return (
|
||||
List
|
||||
Note
|
||||
.objects
|
||||
.filter(Q(owner=user) | Q(shared_with=user))
|
||||
.annotate(last_item=Max('item__id'))
|
||||
@@ -45,18 +45,18 @@ def home_page(request):
|
||||
}
|
||||
if request.user.is_authenticated:
|
||||
context["applets"] = applet_context(request.user, "dashboard")
|
||||
context["recent_lists"] = _recent_lists(request.user)
|
||||
context["recent_notes"] = _recent_notes(request.user)
|
||||
return render(request, "apps/dashboard/home.html", context)
|
||||
|
||||
def new_list(request):
|
||||
def new_note(request):
|
||||
form = ItemForm(data=request.POST)
|
||||
if form.is_valid():
|
||||
nulist = List.objects.create()
|
||||
nunote = Note.objects.create()
|
||||
if request.user.is_authenticated:
|
||||
nulist.owner = request.user
|
||||
nulist.save()
|
||||
form.save(for_list=nulist)
|
||||
return redirect(nulist)
|
||||
nunote.owner = request.user
|
||||
nunote.save()
|
||||
form.save(for_note=nunote)
|
||||
return redirect(nunote)
|
||||
else:
|
||||
context = {
|
||||
"form": form,
|
||||
@@ -65,46 +65,46 @@ def new_list(request):
|
||||
}
|
||||
if request.user.is_authenticated:
|
||||
context["applets"] = applet_context(request.user, "dashboard")
|
||||
context["recent_lists"] = _recent_lists(request.user)
|
||||
context["recent_notes"] = _recent_notes(request.user)
|
||||
return render(request, "apps/dashboard/home.html", context)
|
||||
|
||||
def view_list(request, list_id):
|
||||
our_list = List.objects.get(id=list_id)
|
||||
def view_note(request, note_id):
|
||||
our_note = Note.objects.get(id=note_id)
|
||||
|
||||
if our_list.owner:
|
||||
if our_note.owner:
|
||||
if not request.user.is_authenticated:
|
||||
return redirect("/")
|
||||
if request.user != our_list.owner and request.user not in our_list.shared_with.all():
|
||||
if request.user != our_note.owner and request.user not in our_note.shared_with.all():
|
||||
return HttpResponseForbidden()
|
||||
|
||||
form = ExistingListItemForm(for_list=our_list)
|
||||
form = ExistingNoteItemForm(for_note=our_note)
|
||||
|
||||
if request.method == "POST":
|
||||
form = ExistingListItemForm(for_list=our_list, data=request.POST)
|
||||
form = ExistingNoteItemForm(for_note=our_note, data=request.POST)
|
||||
if form.is_valid():
|
||||
form.save()
|
||||
return redirect(our_list)
|
||||
return render(request, "apps/dashboard/list.html", {"list": our_list, "form": form})
|
||||
|
||||
def my_lists(request, user_id):
|
||||
return redirect(our_note)
|
||||
return render(request, "apps/dashboard/note.html", {"note": our_note, "form": form})
|
||||
|
||||
def my_notes(request, user_id):
|
||||
owner = User.objects.get(id=user_id)
|
||||
if not request.user.is_authenticated:
|
||||
return redirect("/")
|
||||
if request.user.id != owner.id:
|
||||
return HttpResponseForbidden()
|
||||
return render(request, "apps/dashboard/my_lists.html", {"owner": owner})
|
||||
return render(request, "apps/dashboard/my_notes.html", {"owner": owner})
|
||||
|
||||
def share_list(request, list_id):
|
||||
our_list = List.objects.get(id=list_id)
|
||||
def share_note(request, note_id):
|
||||
our_note = Note.objects.get(id=note_id)
|
||||
try:
|
||||
recipient = User.objects.get(email=request.POST["recipient"])
|
||||
if recipient == request.user:
|
||||
return redirect(our_list)
|
||||
our_list.shared_with.add(recipient)
|
||||
return redirect(our_note)
|
||||
our_note.shared_with.add(recipient)
|
||||
except User.DoesNotExist:
|
||||
pass
|
||||
messages.success(request, "An invite has been sent if that address is registered.")
|
||||
return redirect(our_list)
|
||||
return redirect(our_note)
|
||||
|
||||
@login_required(login_url="/")
|
||||
def set_palette(request):
|
||||
@@ -137,7 +137,7 @@ def toggle_applets(request):
|
||||
"applets": applet_context(request.user, "dashboard"),
|
||||
"palettes": PALETTES,
|
||||
"form": ItemForm(),
|
||||
"recent_lists": _recent_lists(request.user),
|
||||
"recent_notes": _recent_notes(request.user),
|
||||
})
|
||||
return redirect("home")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user