@taxman Debits & credits ledger + NVM-persistent FREE/PAID DRAW Briefs — TDD
User-spec 2026-05-26 for /gameboard/my-sea/. The transient "Free draw locked" Brief that re-appeared on every page load is replaced by a server-driven Brief whose NVM dismissal persists per-cycle, AND every spend now lands a permanent line on a new @taxman-authored "Debits & credits" Post (so the info goes somewhere instead of vanishing on dismiss). Same NVM-persistence treatment for the new PAID DRAW Brief. Lyric: - RESERVED_USERNAMES adds "taxman"; get_or_create_taxman() parallels get_or_create_adman() (username=taxman, email=taxman@earthmanrpg.local, unusable password, searchable=False). - New nullable User.{free,paid}_draw_brief_dismissed_at DateTimeFields — anchor stamps for the NVM-persistence semantics. Cleared by my_sea_lock (free) / my_sea_paid_draw (paid) on each fresh spend so the new cycle re-opens the Brief surface. - Migration 0014_brief_dismissal_fields adds the fields + RunPython seeds @taxman (mirror of 0003_seed_adman). Billboard: - Post.KIND_TAX_LEDGER + TAX_LEDGER_POST_TITLE = "Debits & credits"; Brief.KIND_TAX_LEDGER for routing. - _delete_unsolicited_admin_post_lines extended via _SYSTEM_AUTHOR_POST_KINDS tuple — TAX_LEDGER joins NOTE_UNLOCK in the post_save guard that nukes any Line w.o. admin_solicited=True. - Brief.to_banner_dict adds dismiss_url slot (empty by default; populated by the gameboard view for TAX_LEDGER briefs) + uses line.display_text instead of line.text so the prefix is stripped on the banner too. - Line.display_text property — strips the leading "[iso-timestamp] " prefix that log_tax_debit bakes into TAX_LEDGER Lines (the prefix exists ONLY to satisfy unique_together = (post, text) on repeat-slug spends; the per-Brief + per-Line created_at slots already render the user-facing moment). Identity for non-tax Lines. - view_post / delete_post / abandon_post guards extended to treat TAX_LEDGER like NOTE_UNLOCK (POST forbidden, can't delete, can't bye). - Migration 0008_tax_ledger_kind registers the new choices on Post.kind + Brief.kind. Billboard tax module (new apps/billboard/tax.py): - TAX_DEBIT_TEMPLATES — canonical body text per slug, with FREE DRAW / PAID DRAW / GATE VIEW button-labels wrapped in .btn-pri-name spans: - free_draw_locked → "Look!—my_sea.html [FREE DRAW] is locked. Next free draw available 24h from the production of this log." - paid_draw_locked → "Look!—my_sea.html [PAID DRAW] is locked. Another may be unlocked by depositing a Token in [GATE VIEW]." - log_tax_debit(user, slug) — get-or-creates the user's TAX_LEDGER Post, appends a timestamp-prefixed Line authored by @taxman w. admin_solicited=True, spawns a Brief. Returns (post, line, brief). Gameboard: - my_sea_lock first-card-of-cycle branch calls log_tax_debit(user, "free_draw_locked") + clears free_draw_brief_dismissed_at. Response now includes free_draw_brief_payload (Brief.to_banner_dict w. dismiss_url populated) so the picker IIFE can surface the new Brief in-place w.o. a page reload — same affordance the prior _showFreeDrawLockedBrief provided, w. server-authored copy + NVM-persistence. - my_sea_paid_draw after paid_through_at stamp calls log_tax_debit(user, "paid_draw_locked") + clears paid_draw_brief_dismissed_at. Next-page-load surfaces the new Brief via the context payload. - New my_sea_dismiss_free_draw_brief + my_sea_dismiss_paid_draw_brief POST endpoints stamp the matching User anchor field; return 204. URLs at /gameboard/my-sea/brief/{free,paid}-draw/dismiss. - my_sea view's context computes {free,paid}_draw_brief_payload via the new _tax_brief_payload(user, slug_marker, dismissed_at, dismiss_url) helper — returns the latest TAX_LEDGER Brief's to_banner_dict IF (dismissal anchor is None OR anchor < brief.created_at). Slug discrimination via line__text__contains="FREE DRAW" / "PAID DRAW" (kept the Brief schema flat — only two markers today, non-overlapping wordings). Frontend (apps/dashboard/static/apps/dashboard/note.js): - Brief.showBanner NVM handler now fires a fire-and-forget POST to brief.dismiss_url (if present) before removing the banner. Persistent-NVM kinds (TAX_LEDGER) supply it; transient kinds leave the field empty + the handler no-ops to the existing dismiss-only behavior. CSRF token pulled from the csrftoken cookie. SCSS (static_src/scss/_billboard.scss): - .post-line--system .post-line-text .btn-pri-name — inline emphasis (color: --quaUser, font-weight: 700, font-style: normal) on canonical .btn-primary button labels referenced in @taxman ledger prose. User-spec 2026-05-26 mid-flight clarification: log surface only, not the actual buttons. Templates: - templates/apps/gameboard/my_sea.html: replaces the inline _showFreeDrawLockedBrief({{ next_free_draw_at|date:'c' }}) invocation w. two {% if *_brief_payload %} blocks that json_script the payload + dispatch via a new _showTaxBrief(payload, bannerClass) helper. _postLock updated to call _showFreeDrawLockedBrief(body.free_draw_brief_payload) so freshly-emitted Briefs surface in-place w.o. a reload (same affordance as before, w. server payload). - templates/apps/billboard/post.html: readonly-textarea / system-author-styling / bud-panel-suppression branches all extended to cover post.kind == 'tax_ledger' (parallel to existing 'note_unlock' cases). Line-text rendering uses line.display_text (strips the iso prefix) + treats @taxman the same as @adman (allow HTML rendering for the system-author safe text — required so the .btn-pri-name spans aren't escaped). Tests: UTs (apps/billboard/tests/integrated/test_tax.py — 11 specs): - log_tax_debit creates Post/Line/Brief w. correct kind + author + admin_solicited. - Both slug templates produce expected text (assertions tolerant of inline .btn-pri-name span HTML). - Two spends share one Post w. two distinct Lines (timestamp prefix keeps unique_together happy). - Unknown slug raises KeyError. - post_save guard nukes unsolicited Lines on TAX_LEDGER Posts; solicited Lines survive. - "taxman" is reserved (case-insensitive); get_or_create_taxman idempotent. ITs (apps/gameboard/tests/integrated/test_tax_briefs.py — 13 specs): - my_sea_lock first-card creates TAX_LEDGER Post + Line + Brief; mid-cycle upserts do NOT emit extra debits; clears free_draw_brief_dismissed_at. - my_sea_paid_draw commit creates a separate TAX_LEDGER entry; clears paid_draw_brief_dismissed_at. - Dismiss endpoints stamp the matching User anchor; reject GET (405); require login (302). - my_sea context: *_brief_payload is None until first spend; populated after; suppressed after NVM-dismiss; returns after cycle reset. Existing ITs adjusted (apps/gameboard/tests/integrated/test_views.py): - test_view_triggers_brief_banner_when_active_draw_exists + test_empty_hand_brief_banner_still_triggered + test_view_does_not_trigger_brief_banner_without_active_draw — assertions retargeted from window._showFreeDrawLockedBrief(" to id="id_free_draw_brief_payload" (the new json_script payload tag). - test_brief_next_free_draw_at_uses_user_anchor_not_paid_row — switched from HTML-substring assertion against the rendered ISO (now absent from the page) to a direct response.context["next_free_draw_at"] comparison. Same underlying invariant; cleaner assertion shape. FT (functional_tests/test_bill_post_debits_credits.py — 1 spec): - After two seeded debits, /billboard/post/<uuid>/ renders the "Debits & credits" title, both Line bodies (FREE DRAW + PAID DRAW), @taxman attribution, readonly input w. "No response needed at this time" placeholder, AND verifies the "[iso] " prefix is stripped from display. All 1340 IT+UT green; new FT green; existing FTs unaffected by these changes. Pending follow-up (recorded for next sprint): Per user 2026-05-26 in-flight ask: refactor @adman concerns into apps/billboard/ad.py (paralleling the new apps/billboard/tax.py) — extract Note.grant_if_new's billboard-side concerns (Post/Line/Brief creation, prose templates) out of apps/drama/models.py into the same shape log_tax_debit now follows. Notated for after this sprint lands. Code architected by Disco DeDisco <discodedisco@outlook.com> Git commit message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Disco DeDisco
@@ -306,6 +306,27 @@ def my_sea(request):
|
||||
"name": c.name if c else "",
|
||||
}
|
||||
|
||||
# @taxman Brief payloads w. NVM-persistence (user-spec 2026-05-26). The
|
||||
# FREE DRAW Brief surfaces ONLY when an active draw exists AND the user
|
||||
# hasn't NVM-dismissed since the cycle began. PAID DRAW Brief is
|
||||
# independent — surfaces while a PAID DRAW commit has happened in this
|
||||
# cycle (paid_through_at OR a prior commit) AND the paid-draw NVM
|
||||
# anchor is older than the latest paid-draw brief.
|
||||
from django.urls import reverse
|
||||
free_draw_brief_payload = None
|
||||
paid_draw_brief_payload = None
|
||||
if active_draw is not None:
|
||||
free_draw_brief_payload = _tax_brief_payload(
|
||||
request.user, "FREE DRAW",
|
||||
request.user.free_draw_brief_dismissed_at,
|
||||
reverse("my_sea_dismiss_free_draw_brief"),
|
||||
)
|
||||
paid_draw_brief_payload = _tax_brief_payload(
|
||||
request.user, "PAID DRAW",
|
||||
request.user.paid_draw_brief_dismissed_at,
|
||||
reverse("my_sea_dismiss_paid_draw_brief"),
|
||||
)
|
||||
|
||||
return render(request, "apps/gameboard/my_sea.html", {
|
||||
"user_has_sig": user_has_sig,
|
||||
"no_equipped_deck": no_equipped_deck,
|
||||
@@ -332,6 +353,9 @@ def my_sea(request):
|
||||
"deposit_reserved": deposit_reserved,
|
||||
"paid_through": paid_through,
|
||||
"hand_non_empty": hand_non_empty,
|
||||
# TAX_LEDGER brief payloads (None when not eligible to show)
|
||||
"free_draw_brief_payload": free_draw_brief_payload,
|
||||
"paid_draw_brief_payload": paid_draw_brief_payload,
|
||||
"page_class": "page-gameboard page-my-sea",
|
||||
})
|
||||
|
||||
@@ -347,6 +371,31 @@ def _resolve_sig(user, active_draw):
|
||||
return user.significator, user.significator_reversed
|
||||
|
||||
|
||||
def _tax_brief_payload(user, slug_marker, dismissed_at, dismiss_url):
|
||||
"""Return `Brief.to_banner_dict()` (w. `dismiss_url` populated) for the
|
||||
user's latest TAX_LEDGER Brief whose Line text contains `slug_marker`
|
||||
(e.g. "FREE DRAW" / "PAID DRAW"), IF the user's `dismissed_at` anchor
|
||||
is None OR strictly less than the brief's `created_at`. Returns None
|
||||
otherwise — used by the my_sea view to drive conditional Brief render
|
||||
in the template w. NVM-persistence semantics per user-spec 2026-05-26.
|
||||
|
||||
Slug-marker filtering on Line text keeps the Brief model schema flat
|
||||
(no sub_kind discriminator); FREE/PAID DRAW are the only two TAX_
|
||||
LEDGER markers today + their wordings are non-overlapping."""
|
||||
from apps.billboard.models import Brief
|
||||
brief = (Brief.objects
|
||||
.filter(owner=user, kind=Brief.KIND_TAX_LEDGER,
|
||||
line__text__contains=slug_marker)
|
||||
.order_by("-created_at").first())
|
||||
if brief is None:
|
||||
return None
|
||||
if dismissed_at is not None and dismissed_at >= brief.created_at:
|
||||
return None
|
||||
payload = brief.to_banner_dict()
|
||||
payload["dismiss_url"] = dismiss_url
|
||||
return payload
|
||||
|
||||
|
||||
@login_required(login_url="/")
|
||||
@require_POST
|
||||
def my_sea_lock(request):
|
||||
@@ -429,7 +478,15 @@ def my_sea_lock(request):
|
||||
|
||||
if not request.user.free_draw_cooldown_active:
|
||||
request.user.last_free_draw_at = timezone.now()
|
||||
request.user.save(update_fields=["last_free_draw_at"])
|
||||
# Fresh FREE DRAW cycle → clear the NVM-dismissal anchor so the
|
||||
# newly-emitted Brief surfaces on the next page load. User-spec
|
||||
# 2026-05-26: NVM dismissal persists ONLY until the next FREE
|
||||
# DRAW spend; once that lands, the new ledger entry re-opens the
|
||||
# Brief surface for the new cycle.
|
||||
request.user.free_draw_brief_dismissed_at = None
|
||||
request.user.save(update_fields=[
|
||||
"last_free_draw_at", "free_draw_brief_dismissed_at",
|
||||
])
|
||||
|
||||
draw = MySeaDraw.objects.create(
|
||||
user=request.user,
|
||||
@@ -438,6 +495,16 @@ def my_sea_lock(request):
|
||||
significator_id=sig_id,
|
||||
significator_reversed=request.user.significator_reversed,
|
||||
)
|
||||
# Append the @taxman ledger entry + spawn the Brief. Response carries
|
||||
# the Brief payload so the picker IIFE can surface the banner in-place
|
||||
# w.o. a page reload — same affordance the prior in-template
|
||||
# `_showFreeDrawLockedBrief` provided, just w. server-authored copy +
|
||||
# NVM-persistence via `dismiss_url`.
|
||||
from django.urls import reverse
|
||||
from apps.billboard.tax import log_tax_debit
|
||||
_, _, brief = log_tax_debit(request.user, "free_draw_locked")
|
||||
brief_payload = brief.to_banner_dict()
|
||||
brief_payload["dismiss_url"] = reverse("my_sea_dismiss_free_draw_brief")
|
||||
return JsonResponse({
|
||||
"ok": True,
|
||||
"next_free_draw_at": (
|
||||
@@ -445,6 +512,7 @@ def my_sea_lock(request):
|
||||
if request.user.next_free_draw_at else None
|
||||
),
|
||||
"hand_complete": draw.is_hand_complete,
|
||||
"free_draw_brief_payload": brief_payload,
|
||||
})
|
||||
|
||||
|
||||
@@ -601,9 +669,43 @@ def my_sea_paid_draw(request):
|
||||
"deposit_token_id", "deposit_reserved_at",
|
||||
"paid_through_at", "hand",
|
||||
])
|
||||
# Fresh PAID DRAW commit → clear the PAID DRAW NVM-dismissal anchor +
|
||||
# append the @taxman ledger entry / spawn the Brief. Per user-spec
|
||||
# 2026-05-26 the PAID DRAW Brief NVM-persistence is independent from
|
||||
# FREE DRAW's; each cycle's dismissal lifts on its own next-spend.
|
||||
request.user.paid_draw_brief_dismissed_at = None
|
||||
request.user.save(update_fields=["paid_draw_brief_dismissed_at"])
|
||||
from apps.billboard.tax import log_tax_debit
|
||||
log_tax_debit(request.user, "paid_draw_locked")
|
||||
return redirect(reverse("my_sea") + "?phase=picker")
|
||||
|
||||
|
||||
@login_required(login_url="/")
|
||||
@require_POST
|
||||
def my_sea_dismiss_free_draw_brief(request):
|
||||
"""Stamp `User.free_draw_brief_dismissed_at` so the FREE DRAW Brief
|
||||
stays suppressed on subsequent page loads until the next FREE DRAW is
|
||||
spent (`my_sea_lock` clears the anchor on a fresh-cycle commit, re-
|
||||
opening the Brief surface for the new cycle).
|
||||
|
||||
User-spec 2026-05-26: NVM-persistence for the FREE DRAW Brief. Fire-
|
||||
and-forget POST from `note.js`'s NVM click handler; returns 204."""
|
||||
request.user.free_draw_brief_dismissed_at = timezone.now()
|
||||
request.user.save(update_fields=["free_draw_brief_dismissed_at"])
|
||||
return HttpResponse(status=204)
|
||||
|
||||
|
||||
@login_required(login_url="/")
|
||||
@require_POST
|
||||
def my_sea_dismiss_paid_draw_brief(request):
|
||||
"""Stamp `User.paid_draw_brief_dismissed_at` so the PAID DRAW Brief
|
||||
stays suppressed on subsequent page loads until the next PAID DRAW
|
||||
commit. Mirror of `my_sea_dismiss_free_draw_brief`."""
|
||||
request.user.paid_draw_brief_dismissed_at = timezone.now()
|
||||
request.user.save(update_fields=["paid_draw_brief_dismissed_at"])
|
||||
return HttpResponse(status=204)
|
||||
|
||||
|
||||
@login_required(login_url="/")
|
||||
@require_POST
|
||||
def my_sea_invite(request):
|
||||
|
||||
Reference in New Issue
Block a user