From e8687dc050941a42e39d5e274b5651a845e27c99 Mon Sep 17 00:00:00 2001 From: Disco DeDisco Date: Wed, 22 Apr 2026 22:43:50 -0400 Subject: [PATCH] =?UTF-8?q?note=20banner=20NVM:=20btn-danger=20=E2=86=92?= =?UTF-8?q?=20btn-cancel=20(orange)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Sonnet 4.6 --- src/apps/dashboard/static/apps/dashboard/note.js | 2 +- src/functional_tests/test_applet_my_notes.py | 6 +++--- src/static_src/tests/NoteSpec.js | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/apps/dashboard/static/apps/dashboard/note.js b/src/apps/dashboard/static/apps/dashboard/note.js index 9526594..adeec52 100644 --- a/src/apps/dashboard/static/apps/dashboard/note.js +++ b/src/apps/dashboard/static/apps/dashboard/note.js @@ -20,7 +20,7 @@ const Note = (() => { '' + '' + '
' + - '' + + '' + 'FYI'; banner.querySelector('.note-banner__nvm').addEventListener('click', function () { diff --git a/src/functional_tests/test_applet_my_notes.py b/src/functional_tests/test_applet_my_notes.py index 2fa0bc1..83fa98a 100644 --- a/src/functional_tests/test_applet_my_notes.py +++ b/src/functional_tests/test_applet_my_notes.py @@ -150,7 +150,7 @@ class StargazerNoteFromDashboardTest(FunctionalTest): banner.find_element(By.CSS_SELECTOR, ".note-banner__description") banner.find_element(By.CSS_SELECTOR, ".note-banner__timestamp") banner.find_element(By.CSS_SELECTOR, ".note-banner__image") - banner.find_element(By.CSS_SELECTOR, ".btn.btn-danger") # NVM + banner.find_element(By.CSS_SELECTOR, ".btn.btn-cancel") # NVM fyi = banner.find_element(By.CSS_SELECTOR, ".btn.btn-caution") # FYI # FYI navigates to Note page @@ -296,7 +296,7 @@ class StargazerNoteFromSkyPageTest(FunctionalTest): def test_first_valid_save_on_sky_page_fires_banner_and_nvm_dismisses(self): """First valid SAVE SKY on /dashboard/sky/ fires the Stargazer banner. - NVM (.btn.btn-danger) dismisses it.""" + NVM (.btn.btn-cancel) dismisses it.""" self.create_pre_authenticated_session("stargazer@test.io") self.browser.get(self.sky_url) @@ -316,7 +316,7 @@ class StargazerNoteFromSkyPageTest(FunctionalTest): banner.find_element(By.CSS_SELECTOR, ".note-banner__title").text, ) - banner.find_element(By.CSS_SELECTOR, ".btn.btn-danger").click() + banner.find_element(By.CSS_SELECTOR, ".btn.btn-cancel").click() self.wait_for(lambda: self.assertFalse( self.browser.find_elements(By.CSS_SELECTOR, ".note-banner") )) diff --git a/src/static_src/tests/NoteSpec.js b/src/static_src/tests/NoteSpec.js index d906fae..8029e45 100644 --- a/src/static_src/tests/NoteSpec.js +++ b/src/static_src/tests/NoteSpec.js @@ -88,9 +88,9 @@ describe('Note.showBanner', () => { // ── T7 ── NVM button ────────────────────────────────────────────────────── - it('T7: banner has a .btn.btn-danger NVM button', () => { + it('T7: banner has a .btn.btn-cancel NVM button', () => { Note.showBanner(SAMPLE_NOTE); - expect(document.querySelector('.note-banner .btn.btn-danger')).not.toBeNull(); + expect(document.querySelector('.note-banner .btn.btn-cancel')).not.toBeNull(); }); // ── T8 ── FYI link ──────────────────────────────────────────────────────── @@ -106,7 +106,7 @@ describe('Note.showBanner', () => { it('T9: clicking the NVM button removes the banner from the DOM', () => { Note.showBanner(SAMPLE_NOTE); - document.querySelector('.note-banner .btn.btn-danger').click(); + document.querySelector('.note-banner .btn.btn-cancel').click(); expect(document.querySelector('.note-banner')).toBeNull(); });