From a97cd8dcff4a42f1de112d95616e0b12687b2f2a Mon Sep 17 00:00:00 2001
From: Disco DeDisco <adamcraighamilton@gmail.com>
Date: Mon, 4 May 2026 02:23:47 -0400
Subject: [PATCH] =?UTF-8?q?test=5Fclicking=5Fpick=5Fsea=5Fbtn=5Fopens=5Fse?=
 =?UTF-8?q?a=5Foverlay:=20poll=20click+sea-open=20assertion=20to=20absorb?=
 =?UTF-8?q?=20DOM-vs-script=20race=20on=20slow=20CI=20=E2=80=94=20TDD?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The PICK SEA btn parses into the DOM before the inline `<script>` at the bottom of _sea_overlay.html binds `openSea` to it; on fast hosts the gap is invisible but the two-browser CI stage was clicking ahead of the binding and the handler never fired. Wrapping the click + sea-open class assertion in wait_for retries the click until the handler has bound.

Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/functional_tests/test_room_sea_select.py | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/functional_tests/test_room_sea_select.py b/src/functional_tests/test_room_sea_select.py
index 5859374..c612290 100644
--- a/src/functional_tests/test_room_sea_select.py
+++ b/src/functional_tests/test_room_sea_select.py
@@ -132,12 +132,21 @@ class PickSeaAsyncTransitionTest(ChannelsFunctionalTest):
         self.wait_for(lambda: self.browser.find_element(By.ID, "id_pick_sky_btn"))
 
         self._confirm_sky()
-        pick_sea = self.wait_for(lambda: self.browser.find_element(By.ID, "id_pick_sea_btn"))
-        self.browser.execute_script("arguments[0].click()", pick_sea)
+        self.wait_for(lambda: self.browser.find_element(By.ID, "id_pick_sea_btn"))
 
-        sea_overlay = self.wait_for(
-            lambda: self.browser.find_element(By.ID, "id_sea_overlay")
-        )
+        # On slow CI, the PICK SEA btn parses into the DOM before the inline
+        # `<script>` at the bottom of _sea_overlay.html has bound `openSea` to
+        # it; a one-shot click can land before the handler exists. Retry click
+        # + assert together via wait_for so the race resolves naturally.
+        def _click_and_assert_sea_open():
+            btn = self.browser.find_element(By.ID, "id_pick_sea_btn")
+            self.browser.execute_script("arguments[0].click()", btn)
+            self.assertTrue(self.browser.execute_script(
+                "return document.documentElement.classList.contains('sea-open')"
+            ))
+        self.wait_for(_click_and_assert_sea_open)
+
+        sea_overlay = self.browser.find_element(By.ID, "id_sea_overlay")
         self.assertTrue(sea_overlay.is_displayed())