COVERAGE: patch 91% → 96%+ — 603 tests, tasks.py at 100%
New/extended tests across billboard, dashboard, drama, epic, gameboard, and lyric to cover previously untested branches: dev_login view, scroll position endpoints, sky preview error paths, drama to_prose/to_activity branches, consumer broadcast handlers, tarot deck draw/shuffle, astrology model __str__, character model, sig reserve/ready/confirm views, natus preview/save views, and the full tasks.py countdown scheduler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1612,3 +1612,278 @@ class PickSkyRenderingTest(TestCase):
|
||||
response = self.client.get(self.url)
|
||||
self.assertContains(response, 'id="id_pick_sky_btn"')
|
||||
self.assertContains(response, 'style="display:none"')
|
||||
|
||||
|
||||
# ── select_role GET redirect ──────────────────────────────────────────────────
|
||||
|
||||
class SelectRoleGetRedirectTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="gamer@sr.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room = Room.objects.create(name="R", owner=self.user)
|
||||
self.room.table_status = Room.ROLE_SELECT
|
||||
self.room.save()
|
||||
|
||||
def test_get_redirects_to_room(self):
|
||||
response = self.client.get(reverse("epic:select_role", kwargs={"room_id": self.room.id}))
|
||||
self.assertRedirects(response, reverse("epic:room", kwargs={"room_id": self.room.id}),
|
||||
fetch_redirect_response=False)
|
||||
|
||||
|
||||
# ── sig_reserve / sig_ready / sig_confirm / select_sig helpers ────────────────
|
||||
|
||||
def _make_sig_room(owner, *extra_gamers):
|
||||
room = Room.objects.create(name="SR", owner=owner)
|
||||
seat_map = {}
|
||||
gamers = [owner] + list(extra_gamers)
|
||||
roles = ["PC", "NC", "EC", "SC", "AC", "BC"]
|
||||
for i, (gamer, role) in enumerate(zip(gamers, roles), start=1):
|
||||
seat = TableSeat.objects.create(room=room, gamer=gamer, slot_number=i, role=role)
|
||||
seat_map[role] = seat
|
||||
room.table_status = Room.SIG_SELECT
|
||||
room.save()
|
||||
return room, seat_map
|
||||
|
||||
|
||||
class SigReserveViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@sig.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, self.seats = _make_sig_room(self.user)
|
||||
self.card = TarotCard.objects.first()
|
||||
|
||||
def test_non_post_returns_405(self):
|
||||
response = self.client.get(reverse("epic:sig_reserve", kwargs={"room_id": self.room.id}))
|
||||
self.assertEqual(response.status_code, 405)
|
||||
|
||||
def test_reserve_action_succeeds(self):
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_reserve", kwargs={"room_id": self.room.id}),
|
||||
{"action": "reserve", "card_id": str(self.card.pk)},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertTrue(SigReservation.objects.filter(room=self.room, gamer=self.user).exists())
|
||||
|
||||
def test_release_action_removes_reservation(self):
|
||||
SigReservation.objects.create(
|
||||
room=self.room, gamer=self.user, card=self.card,
|
||||
polarity=SigReservation.LEVITY, seat=self.seats["PC"],
|
||||
)
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_reserve", kwargs={"room_id": self.room.id}),
|
||||
{"action": "release"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertFalse(SigReservation.objects.filter(room=self.room, gamer=self.user).exists())
|
||||
|
||||
|
||||
class SigReadyViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@ready.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, self.seats = _make_sig_room(self.user)
|
||||
self.card = (
|
||||
TarotCard.objects.filter(arcana=TarotCard.MIDDLE).first()
|
||||
or TarotCard.objects.first()
|
||||
)
|
||||
self.res = SigReservation.objects.create(
|
||||
room=self.room, gamer=self.user, card=self.card,
|
||||
polarity=SigReservation.LEVITY, seat=self.seats["PC"],
|
||||
)
|
||||
|
||||
def test_non_post_returns_405(self):
|
||||
response = self.client.get(reverse("epic:sig_ready", kwargs={"room_id": self.room.id}))
|
||||
self.assertEqual(response.status_code, 405)
|
||||
|
||||
def test_ready_action_sets_ready_flag(self):
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_ready", kwargs={"room_id": self.room.id}),
|
||||
{"action": "ready"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.res.refresh_from_db()
|
||||
self.assertTrue(self.res.ready)
|
||||
|
||||
def test_ready_action_idempotent_when_already_ready(self):
|
||||
self.res.ready = True
|
||||
self.res.save()
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_ready", kwargs={"room_id": self.room.id}),
|
||||
{"action": "ready"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
def test_unready_action_saves_seconds_remaining(self):
|
||||
self.res.ready = True
|
||||
self.res.save()
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_ready", kwargs={"room_id": self.room.id}),
|
||||
{"action": "unready", "seconds_remaining": "7"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.res.refresh_from_db()
|
||||
self.assertEqual(self.res.countdown_remaining, 7)
|
||||
|
||||
def test_unready_action_handles_invalid_seconds_remaining(self):
|
||||
self.res.ready = True
|
||||
self.res.save()
|
||||
response = self.client.post(
|
||||
reverse("epic:sig_ready", kwargs={"room_id": self.room.id}),
|
||||
{"action": "unready", "seconds_remaining": "abc"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.res.refresh_from_db()
|
||||
self.assertEqual(self.res.countdown_remaining, 12)
|
||||
|
||||
|
||||
class SigConfirmViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@confirm.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, self.seats = _make_sig_room(self.user)
|
||||
|
||||
def test_non_post_returns_405(self):
|
||||
response = self.client.get(reverse("epic:sig_confirm", kwargs={"room_id": self.room.id}))
|
||||
self.assertEqual(response.status_code, 405)
|
||||
|
||||
|
||||
class SelectSigViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@selsig.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, self.seats = _make_sig_room(self.user)
|
||||
|
||||
def test_non_post_redirects(self):
|
||||
response = self.client.get(reverse("epic:select_sig", kwargs={"room_id": self.room.id}))
|
||||
self.assertEqual(response.status_code, 302)
|
||||
|
||||
def test_nonexistent_card_returns_400(self):
|
||||
response = self.client.post(
|
||||
reverse("epic:select_sig", kwargs={"room_id": self.room.id}),
|
||||
{"card_id": "99999999"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
|
||||
# ── natus_preview (epic) ──────────────────────────────────────────────────────
|
||||
|
||||
class NatusPreviewViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@natus.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, _ = _make_sig_room(self.user)
|
||||
self.room.table_status = Room.SKY_SELECT
|
||||
self.room.save()
|
||||
self.url = reverse("epic:natus_preview", kwargs={"room_id": self.room.id})
|
||||
|
||||
def test_missing_params_returns_400(self):
|
||||
response = self.client.get(self.url, {"date": "1990-06-15"})
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
def test_non_numeric_lat_returns_400(self):
|
||||
response = self.client.get(self.url, {"date": "1990-06-15", "lat": "abc", "lon": "0"})
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
def test_out_of_range_lat_returns_400(self):
|
||||
response = self.client.get(self.url, {"date": "1990-06-15", "lat": "999", "lon": "0"})
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
def test_invalid_tz_string_returns_400(self):
|
||||
response = self.client.get(
|
||||
self.url,
|
||||
{"date": "1990-06-15", "lat": "51.5", "lon": "-0.1", "tz": "Not/Real"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
def test_bad_date_format_returns_400(self):
|
||||
response = self.client.get(
|
||||
self.url,
|
||||
{"date": "baddate", "time": "09:00", "lat": "51.5", "lon": "-0.1", "tz": "UTC"},
|
||||
)
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
@patch("apps.epic.views.http_requests")
|
||||
def test_pyswiss_failure_returns_502(self, mock_requests):
|
||||
from unittest.mock import MagicMock
|
||||
tz_r = MagicMock()
|
||||
tz_r.json.return_value = {"timezone": "UTC"}
|
||||
tz_r.raise_for_status = MagicMock()
|
||||
chart_r = MagicMock()
|
||||
chart_r.raise_for_status.side_effect = Exception("timeout")
|
||||
mock_requests.get.side_effect = [tz_r, chart_r]
|
||||
response = self.client.get(self.url, {"date": "1990-06-15", "lat": "51.5", "lon": "-0.1"})
|
||||
self.assertEqual(response.status_code, 502)
|
||||
|
||||
@patch("apps.epic.views.http_requests")
|
||||
def test_success_returns_chart_distinctions_timezone(self, mock_requests):
|
||||
from unittest.mock import MagicMock
|
||||
payload = {
|
||||
"planets": {"Sun": {"degree": 84.5}},
|
||||
"houses": {"cusps": [0] * 12},
|
||||
"elements": {"Earth": 1},
|
||||
"house_system": "O",
|
||||
}
|
||||
tz_r = MagicMock()
|
||||
tz_r.json.return_value = {"timezone": "Europe/London"}
|
||||
tz_r.raise_for_status = MagicMock()
|
||||
ch_r = MagicMock()
|
||||
ch_r.json.return_value = payload
|
||||
ch_r.raise_for_status = MagicMock()
|
||||
mock_requests.get.side_effect = [tz_r, ch_r]
|
||||
response = self.client.get(self.url, {"date": "1990-06-15", "lat": "51.5", "lon": "-0.1"})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
data = response.json()
|
||||
self.assertIn("distinctions", data)
|
||||
self.assertIn("Stone", data["elements"])
|
||||
self.assertNotIn("Earth", data["elements"])
|
||||
|
||||
|
||||
# ── natus_save (epic) ─────────────────────────────────────────────────────────
|
||||
|
||||
class NatusSaveViewTest(TestCase):
|
||||
def setUp(self):
|
||||
self.user = User.objects.create(email="pc@natussave.io")
|
||||
self.client.force_login(self.user)
|
||||
self.room, _ = _make_sig_room(self.user)
|
||||
self.room.table_status = Room.SKY_SELECT
|
||||
self.room.save()
|
||||
self.url = reverse("epic:natus_save", kwargs={"room_id": self.room.id})
|
||||
|
||||
def _post(self, payload):
|
||||
import json as _json
|
||||
return self.client.post(self.url, data=_json.dumps(payload), content_type="application/json")
|
||||
|
||||
def test_get_returns_405(self):
|
||||
response = self.client.get(self.url)
|
||||
self.assertEqual(response.status_code, 405)
|
||||
|
||||
def test_invalid_json_returns_400(self):
|
||||
response = self.client.post(self.url, data="not json", content_type="application/json")
|
||||
self.assertEqual(response.status_code, 400)
|
||||
|
||||
def test_save_draft_returns_id_and_not_confirmed(self):
|
||||
response = self._post({
|
||||
"birth_dt": "1990-06-15T09:00:00Z",
|
||||
"birth_lat": 51.5,
|
||||
"birth_lon": -0.1,
|
||||
"birth_place": "London",
|
||||
"house_system": "O",
|
||||
"chart_data": {},
|
||||
})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
data = response.json()
|
||||
self.assertIn("id", data)
|
||||
self.assertFalse(data["confirmed"])
|
||||
|
||||
def test_confirm_action_locks_character(self):
|
||||
response = self._post({
|
||||
"birth_dt": "1990-06-15T09:00:00Z",
|
||||
"birth_lat": 51.5,
|
||||
"birth_lon": -0.1,
|
||||
"birth_place": "",
|
||||
"house_system": "O",
|
||||
"chart_data": {},
|
||||
"action": "confirm",
|
||||
})
|
||||
self.assertEqual(response.status_code, 200)
|
||||
self.assertTrue(response.json()["confirmed"])
|
||||
|
||||
Reference in New Issue
Block a user