post aperture refactor (May-8b): Post.title field; Line.author PROTECT FK + created_at; Note.grant_if_new admin-vs-Look! format dispatch w. note-ref anchor; bottom-anchored aperture w. shared-between header + per-Line user/timestamp; dotted-? Brief square; reserved adman seed — TDD

- schema: billboard/0004 adds Post.title (CharField 35) + Line.author (PROTECT FK, related_name=authored_lines) + Line.created_at (auto_now_add); RunPython backfill stamps existing rows (note_unlock → "Notes & recognitions" + author=adman; user_post → first-line glean + author=Post.owner).
  - lyric/0003 seeds adman User (system author for note unlock + share invite Lines); apps.lyric.models gains RESERVED_USERNAMES = {"adman"}, is_reserved_username() guard in dashboard.set_profile, get_or_create_adman() lazy fetch (TransactionTestCase flushes the seed).
  - drama: Note.grant_if_new dispatches via _ADMIN_NOTE_SLUGS = {"super-schizo","super-nomad"} — admin slugs use "The administration recognizes…" prose; everyone else uses "Look!—new Note unlocked." Both wrap Note name in `<a class="note-ref">`. Header Line dropped (test_two_different_grants_share_one_post asserts 2 lines, not 3). Note.display_name property added (slug.title() default — "super-schizo" → "Super-Schizo"). User.active_title_display returns donned recognition title or "Earthman" default.
  - billboard models: Post.name property removed → my_posts.html, _applet-my-posts.html, PostSerializer switched to Post.title. LineForm.save(for_post, author) + ExistingPostLineForm.save(author) signature + all callers (api.views, billboard.views.new_post + view_post + share_post). billboard.views.share_post authors via get_or_create_adman; new_post truncates first line for Post.title via _truncate_post_title.
  - post.html: <h3> post title heading; .post-shared-recipients (commas only) + .post-shared-self lines ("just me, X the Earthman" / "& me, X the Y" 0/≥1 split); #id_post_table is now a <ul> w. justify-content: flex-end + per-Line 3-col grid (author/text/time); adman Lines render |safe + .post-line--system italic; #id_text → #id_post_line_text rename (post.html only — /billboard/ new-post applet keeps #id_text); page_class page-billpost (joins billboard+billscroll body-class trio).
  - SCSS _billboard.scss: .post-page extends %billboard-page-base, adds bottom-anchored flex-column scroll + 3-col .post-line grid + .post-line-form pinned at bottom. _note.scss: a.note-banner__image picks up .note-item__image-box dashed-? styling for the Brief square.
  - _buddy_panel.html JS rewired for new layout: _appendLine builds <li class="post-line post-line--system"> w. adman+timestamp; _appendRecipientChip handles 0→1+ transition (rewrites "just me," → "& me,", inserts .post-shared-recipients line above self).
  - FT post_page.py: get_table_rows queries .post-line; wait_for_row_in_post_table matches by text containment (line_number arg ignored — kept for backwards compat); get_line_input_box probes #id_post_line_text first, falls back to #id_text; get_post_owner reads textContent (hidden span). test_applet_new_post_line_validation switched to input[name="text"]:invalid/:valid for cross-page selectors.
  - rootvars.scss: minor plutonium + fuschia tweaks (pre-existing).
  - 818 ITs + 35 FTs (buddy/new-post/sharing/validation/layout/jasmine/my-notes/my-posts) green.

Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Disco DeDisco
2026-05-08 21:29:21 -04:00
parent ba5f6556c0
commit 6f76f6c176
28 changed files with 619 additions and 138 deletions

View File

@@ -0,0 +1,98 @@
# Adds Post.title, Line.author (PROTECT FK to lyric.User), Line.created_at.
# Backfills Post.title from first-line text (truncate 32 + "…" past 35 chars,
# or hardcoded "Notes & recognitions" for KIND_NOTE_UNLOCK), and Line.author
# from Post.owner — except KIND_NOTE_UNLOCK + ownerless rows, which attribute
# to the seeded `adman` User. Depends on lyric/0003_seed_adman so adman
# exists before backfill runs.
from django.db import migrations, models
from django.db.models import deletion
from django.utils import timezone
_NOTE_UNLOCK_TITLE = "Notes & recognitions"
def _truncate_title(text, length=35):
if len(text) <= length:
return text
return text[: length - 3] + "..."
def backfill(apps, schema_editor):
Post = apps.get_model("billboard", "Post")
Line = apps.get_model("billboard", "Line")
User = apps.get_model("lyric", "User")
adman = User.objects.filter(username="adman").first()
for post in Post.objects.all():
if post.kind == "note_unlock":
post.title = _NOTE_UNLOCK_TITLE
else:
first_line = post.lines.order_by("id").first()
post.title = _truncate_title(first_line.text) if first_line else ""
post.save(update_fields=["title"])
now = timezone.now()
for line in Line.objects.select_related("post").all():
if line.post.kind == "note_unlock":
line.author = adman
elif line.post.owner_id:
line.author_id = line.post.owner_id
else:
line.author = adman
if line.created_at is None:
line.created_at = now
line.save(update_fields=["author", "created_at"])
def reverse_noop(apps, schema_editor):
pass
class Migration(migrations.Migration):
dependencies = [
("billboard", "0003_post_kind"),
("lyric", "0003_seed_adman"),
]
operations = [
migrations.AddField(
model_name="post",
name="title",
field=models.CharField(default="", max_length=35),
),
migrations.AddField(
model_name="line",
name="created_at",
field=models.DateTimeField(default=timezone.now),
),
migrations.AddField(
model_name="line",
name="author",
field=models.ForeignKey(
blank=True,
null=True,
on_delete=deletion.PROTECT,
related_name="authored_lines",
to="lyric.user",
),
),
migrations.RunPython(backfill, reverse_noop),
migrations.AlterField(
model_name="line",
name="author",
field=models.ForeignKey(
on_delete=deletion.PROTECT,
related_name="authored_lines",
to="lyric.user",
),
),
migrations.AlterField(
model_name="line",
name="created_at",
field=models.DateTimeField(auto_now_add=True),
),
]