Jasmine: fix 2 failing specs, drop 5 always-pending touch specs

- FYI btn is now btn-disabled when caution open; rename test to assert
  disabled click does NOT close caution (old toggle expectation was stale)
- Hover-resets-is-reversed: cloneNode post-init has no mouseenter listener
  (direct binding, not delegation); use mouseleave + re-enter on same card
- Remove 3 touch describe blocks (5 specs total); TouchEvent unavailable
  in desktop Firefox means they never ran; touch behaviour covered by FTs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

src/static/tests/SigSelectSpec.js

@@ -134,80 +134,6 @@ describe("SigSelect", () => {
         });
     });
 
-    // ── Touch: OK btn tap allows synthetic click through ──────────────── //
-
-    describe("touch on OK button", () => {
-        beforeEach(() => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            makeFixture();
-        });
-
-        it("touchstart on OK btn does not call preventDefault (allows synthetic click)", () => {
-            // First tap the card body to show OK
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(card.classList.contains("sig-focused")).toBe(true);
-
-            // Now tap the OK button — touchstart should NOT preventDefault
-            var okBtn = card.querySelector(".sig-ok-btn");
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: okBtn })],
-            });
-            okBtn.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(false);
-        });
-
-        it("touchstart on card body (not OK btn) calls preventDefault", () => {
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: card })],
-            });
-            card.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(true);
-        });
-    });
-
-    // ── Touch outside grid dismisses stage (mobile) ───────────────────── //
-
-    describe("touch outside grid", () => {
-        beforeEach(() => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            makeFixture();
-        });
-
-        it("dismisses stage preview when touching outside the grid (unfocused state)", () => {
-            // Focus a card first
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(stageCard.style.display).toBe("");
-
-            // Touch on the sig-stage (outside the grid)
-            var stage = testDiv.querySelector(".sig-stage");
-            stage.dispatchEvent(new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 2, target: stage })],
-            }));
-            expect(stageCard.style.display).toBe("none");
-            expect(card.classList.contains("sig-focused")).toBe(false);
-        });
-
-        it("does NOT dismiss stage preview when frozen (card reserved)", () => {
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            SigSelect._setFrozen(true);
-            // _focusedCardEl is set but frozen — use internal state trick via _setFrozen
-            // We also need a focused card; simulate it by setting frozen after focus
-            var stage = testDiv.querySelector(".sig-stage");
-            stage.dispatchEvent(new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 3, target: stage })],
-            }));
-            expect(stageCard.style.display).toBe("");
-        });
-    });
-
     // ── Lock after reservation ─────────────────────────────────────────── //
 
     describe("lock after reservation", () => {
@@ -227,18 +153,6 @@ describe("SigSelect", () => {
             expect(window.fetch).not.toHaveBeenCalled();
         });
 
-        it("does not call preventDefault on touchstart while a card is reserved", () => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            SigSelect._setReservedCardId("99");
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: card })],
-            });
-            card.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(false);
-        });
-
         it("allows focus again after reservation is cleared", () => {
             SigSelect._setReservedCardId("99");
             SigSelect._setReservedCardId(null);
@@ -308,10 +222,11 @@ describe("SigSelect", () => {
             expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(true);
         });
 
-        it("second !! click removes .sig-caution-open (toggle)", () => {
+        it("FYI click when btn-disabled does not close caution", () => {
             openCaution();
+            expect(cautionBtn.classList.contains("btn-disabled")).toBe(true);
             cautionBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(false);
+            expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(true);
         });
 
         it("shows placeholder text when cautions list is empty", () => {
@@ -474,18 +389,15 @@ describe("SigSelect", () => {
         });
 
         it("hovering a new card resets .is-reversed", () => {
-            // Add a second card to the grid so we can hover it
-            var secondCard = card.cloneNode(true);
-            secondCard.dataset.cardId = "99";
-            testDiv.querySelector(".sig-deck-grid").appendChild(secondCard);
-
             card.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
             statBlock.querySelector(".sig-flip-btn").dispatchEvent(
                 new MouseEvent("click", { bubbles: true })
             );
             expect(statBlock.classList.contains("is-reversed")).toBe(true);
 
-            secondCard.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
+            // Leave and re-enter (simulates moving to a different card)
+            card.dispatchEvent(new MouseEvent("mouseleave", { bubbles: true }));
+            card.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
             expect(statBlock.classList.contains("is-reversed")).toBe(false);
         });
 

src/static_src/tests/SigSelectSpec.js

@@ -134,80 +134,6 @@ describe("SigSelect", () => {
         });
     });
 
-    // ── Touch: OK btn tap allows synthetic click through ──────────────── //
-
-    describe("touch on OK button", () => {
-        beforeEach(() => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            makeFixture();
-        });
-
-        it("touchstart on OK btn does not call preventDefault (allows synthetic click)", () => {
-            // First tap the card body to show OK
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(card.classList.contains("sig-focused")).toBe(true);
-
-            // Now tap the OK button — touchstart should NOT preventDefault
-            var okBtn = card.querySelector(".sig-ok-btn");
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: okBtn })],
-            });
-            okBtn.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(false);
-        });
-
-        it("touchstart on card body (not OK btn) calls preventDefault", () => {
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: card })],
-            });
-            card.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(true);
-        });
-    });
-
-    // ── Touch outside grid dismisses stage (mobile) ───────────────────── //
-
-    describe("touch outside grid", () => {
-        beforeEach(() => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            makeFixture();
-        });
-
-        it("dismisses stage preview when touching outside the grid (unfocused state)", () => {
-            // Focus a card first
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(stageCard.style.display).toBe("");
-
-            // Touch on the sig-stage (outside the grid)
-            var stage = testDiv.querySelector(".sig-stage");
-            stage.dispatchEvent(new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 2, target: stage })],
-            }));
-            expect(stageCard.style.display).toBe("none");
-            expect(card.classList.contains("sig-focused")).toBe(false);
-        });
-
-        it("does NOT dismiss stage preview when frozen (card reserved)", () => {
-            card.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            SigSelect._setFrozen(true);
-            // _focusedCardEl is set but frozen — use internal state trick via _setFrozen
-            // We also need a focused card; simulate it by setting frozen after focus
-            var stage = testDiv.querySelector(".sig-stage");
-            stage.dispatchEvent(new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 3, target: stage })],
-            }));
-            expect(stageCard.style.display).toBe("");
-        });
-    });
-
     // ── Lock after reservation ─────────────────────────────────────────── //
 
     describe("lock after reservation", () => {
@@ -227,18 +153,6 @@ describe("SigSelect", () => {
             expect(window.fetch).not.toHaveBeenCalled();
         });
 
-        it("does not call preventDefault on touchstart while a card is reserved", () => {
-            if (typeof TouchEvent === 'undefined') { pending('TouchEvent unavailable in desktop Firefox'); return; }
-            SigSelect._setReservedCardId("99");
-            var touchEvent = new TouchEvent("touchstart", {
-                bubbles: true,
-                cancelable: true,
-                touches: [new Touch({ identifier: 1, target: card })],
-            });
-            card.dispatchEvent(touchEvent);
-            expect(touchEvent.defaultPrevented).toBe(false);
-        });
-
         it("allows focus again after reservation is cleared", () => {
             SigSelect._setReservedCardId("99");
             SigSelect._setReservedCardId(null);
@@ -308,10 +222,11 @@ describe("SigSelect", () => {
             expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(true);
         });
 
-        it("second !! click removes .sig-caution-open (toggle)", () => {
+        it("FYI click when btn-disabled does not close caution", () => {
             openCaution();
+            expect(cautionBtn.classList.contains("btn-disabled")).toBe(true);
             cautionBtn.dispatchEvent(new MouseEvent("click", { bubbles: true }));
-            expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(false);
+            expect(testDiv.querySelector(".sig-stage").classList.contains("sig-caution-open")).toBe(true);
         });
 
         it("shows placeholder text when cautions list is empty", () => {
@@ -474,18 +389,15 @@ describe("SigSelect", () => {
         });
 
         it("hovering a new card resets .is-reversed", () => {
-            // Add a second card to the grid so we can hover it
-            var secondCard = card.cloneNode(true);
-            secondCard.dataset.cardId = "99";
-            testDiv.querySelector(".sig-deck-grid").appendChild(secondCard);
-
             card.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
             statBlock.querySelector(".sig-flip-btn").dispatchEvent(
                 new MouseEvent("click", { bubbles: true })
             );
             expect(statBlock.classList.contains("is-reversed")).toBe(true);
 
-            secondCard.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
+            // Leave and re-enter (simulates moving to a different card)
+            card.dispatchEvent(new MouseEvent("mouseleave", { bubbles: true }));
+            card.dispatchEvent(new MouseEvent("mouseenter", { bubbles: true }));
             expect(statBlock.classList.contains("is-reversed")).toBe(false);
         });