sky_natus_data: return stored sky_chart_data (preserves correct asc)
All checks were successful
ci/woodpecker/push/pyswiss Pipeline was successful
ci/woodpecker/push/main Pipeline was successful

sky_save was re-fetching from PySwiss using sky_birth_dt, which was
stored as local time treated as UTC — giving a different (wrong) asc
than the chart computed by sky_preview. sky_natus_data then served this
wrong chart, rotating the applet wheel by the timezone offset.

Fix: sky_save stores body.get('chart_data') directly (client _lastChartData
is already enriched from sky_preview with correct UTC). sky_natus_data
returns the stored chart with fresh distinctions — no PySwiss call needed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Disco DeDisco
2026-04-21 20:58:16 -04:00
parent b8ac004fb6
commit 3974fdac82
2 changed files with 29 additions and 87 deletions

View File

@@ -529,68 +529,47 @@ class SkySaveViewTest(TestCase):
content_type="application/json",
)
@patch("apps.dashboard.views.http_requests.get")
def test_save_fetches_enriched_data_from_pyswiss(self, mock_get):
mock_resp = MagicMock()
mock_resp.raise_for_status.return_value = None
mock_resp.json.return_value = dict(ENRICHED_CHART)
mock_get.return_value = mock_resp
response = self._post()
self.assertEqual(response.status_code, 200)
self.user.refresh_from_db()
saved = self.user.sky_chart_data
self.assertIsNotNone(saved)
fire = saved["elements"]["Fire"]
self.assertIn("contributors", fire)
self.assertIn("Sun", fire["contributors"])
@patch("apps.dashboard.views.http_requests.get")
def test_save_falls_back_to_client_data_if_pyswiss_unreachable(self, mock_get):
mock_get.side_effect = Exception("connection refused")
client_chart = {"planets": {}, "elements": {"Fire": 2}}
def test_save_stores_client_chart_data(self):
"""sky_save stores the chart_data from the client (already enriched by sky_preview)."""
client_chart = {
"planets": {},
"houses": {"cusps": [float(i * 30) for i in range(12)], "asc": 123.4, "mc": 45.6},
"elements": {"Fire": {"count": 1, "contributors": []}},
}
payload = dict(BIRTH_PAYLOAD, chart_data=client_chart)
response = self._post(payload)
self.assertEqual(response.status_code, 200)
self.user.refresh_from_db()
self.assertEqual(self.user.sky_chart_data, client_chart)
self.assertAlmostEqual(self.user.sky_chart_data["houses"]["asc"], 123.4)
@override_settings(PYSWISS_URL="http://pyswiss-test")
class SkyNatusDataViewTest(TestCase):
def setUp(self):
self.user = User.objects.create(
email="disco@test.io",
sky_birth_lat=51.5,
sky_birth_lon=-0.1,
sky_birth_place="London",
)
self.user = User.objects.create(email="disco@test.io")
self.client.force_login(self.user)
@patch("apps.dashboard.views.http_requests.get")
def test_returns_enriched_chart_data(self, mock_get):
from datetime import datetime, timezone as dt_timezone
self.user.sky_birth_dt = datetime(1990, 6, 15, 12, 0, tzinfo=dt_timezone.utc)
self.user.sky_house_system = "O"
self.user.save(update_fields=["sky_birth_dt", "sky_house_system"])
mock_resp = MagicMock()
mock_resp.raise_for_status.return_value = None
mock_resp.json.return_value = dict(ENRICHED_CHART)
mock_get.return_value = mock_resp
def test_returns_stored_chart_with_asc_preserved(self):
"""sky_natus_data returns sky_chart_data — asc must match what was saved."""
stored = {
"planets": {},
"houses": {"cusps": [float(i * 30) for i in range(12)], "asc": 236.1, "mc": 159.1},
"elements": {"Fire": {"count": 1, "contributors": []}},
"aspects": [],
"house_system": "O",
}
self.user.sky_chart_data = stored
self.user.save(update_fields=["sky_chart_data"])
response = self.client.get("/dashboard/sky/data")
self.assertEqual(response.status_code, 200)
data = json.loads(response.content)
self.assertIn("elements", data)
fire = data["elements"]["Fire"]
self.assertIn("contributors", fire)
self.assertAlmostEqual(data["houses"]["asc"], 236.1)
self.assertIn("distinctions", data)
def test_returns_404_if_no_birth_data_saved(self):
def test_returns_404_if_no_chart_data_saved(self):
response = self.client.get("/dashboard/sky/data")
self.assertEqual(response.status_code, 404)