discoman/python-tdd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PICK SEA crucifix grid: rename CSS position classes + remove dead code

Browse Source 
Stage 1 — free 'cross':
- sea-cross-cell → sea-crucifix-cell (template, Jasmine fixture, SCSS)

Stage 2 — semantic position names:
- sea-pos-past → sea-pos-leave; grid-area: past → leave
- sea-pos-center → sea-pos-core; grid-area: center → core
- sea-pos-future → sea-pos-loom; grid-area: future → loom
- sea-pos-root → sea-pos-lay; grid-area: root → lay
- grid-template-areas updated to match
- sea-pos-crossing removed (dead code — no element ever carried it)

Jasmine + 35 ITs green.

Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Disco DeDisco
2026-04-29 14:19:30 -04:00
parent d728900c24
commit 26a3af21fa
4 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/static/tests/SeaDealSpec.js
View File

@@ -21,13 +21,13 @@ describe("SeaDeal", () => {
<!-- Cross grid (simplified) --> <!-- Cross grid (simplified) -->
<div class="sea-cross"> <div class="sea-cross">
<div class="sea-cross-cell sea-pos-crown"> <div class="sea-crucifix-cell sea-pos-crown">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-past"> <div class="sea-crucifix-cell sea-pos-leave">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-center"> <div class="sea-crucifix-cell sea-pos-core">
<div class="sea-sig-card"></div> <div class="sea-sig-card"></div>
<div class="sea-pos-cover"> <div class="sea-pos-cover">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
@@ -36,10 +36,10 @@ describe("SeaDeal", () => {
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
</div> </div>
<div class="sea-cross-cell sea-pos-future"> <div class="sea-crucifix-cell sea-pos-loom">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-root"> <div class="sea-crucifix-cell sea-pos-lay">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
</div> </div>

19
src/static_src/scss/_card-deck.scss
View File

@@ -778,8 +778,8 @@ html.sea-open .sea-modal-wrap {
display: grid; display: grid;
grid-template-areas: grid-template-areas:
". crown . " ". crown . "
"past center future " "leave core loom "
". root . "; ". lay . ";
grid-template-columns: 1fr 1fr 1fr; grid-template-columns: 1fr 1fr 1fr;
grid-template-rows: auto auto auto; grid-template-rows: auto auto auto;
gap: 0.5rem; gap: 0.5rem;
@@ -787,13 +787,12 @@ html.sea-open .sea-modal-wrap {
justify-items: center; justify-items: center;
} }
.sea-cross-cell { display: flex; align-items: center; justify-content: center; } .sea-crucifix-cell { display: flex; align-items: center; justify-content: center; }
.sea-pos-crown { grid-area: crown; } .sea-pos-crown { grid-area: crown; }
.sea-pos-past { grid-area: past; } .sea-pos-leave { grid-area: leave; }
.sea-pos-center { grid-area: center; } .sea-pos-core { grid-area: core; }
.sea-pos-future { grid-area: future; } .sea-pos-loom { grid-area: loom; }
.sea-pos-root { grid-area: root; } .sea-pos-lay { grid-area: lay; }
.sea-pos-crossing { grid-area: crossing; }
$sea-card-w: 4rem; $sea-card-w: 4rem;
$sea-card-h: 6.5rem; $sea-card-h: 6.5rem;
@@ -874,8 +873,8 @@ $sea-card-h: 6.5rem;
box-shadow: 0 0 0.5rem 0.25rem rgba(var(--ninUser), 0.35), 0 0 0.4rem rgba(0, 0, 0, 0.85); box-shadow: 0 0 0.5rem 0.25rem rgba(var(--ninUser), 0.35), 0 0 0.4rem rgba(0, 0, 0, 0.85);
} }
// Cover + Cross — absolutely overlaid on the Sig card in .sea-pos-center // Cover + Cross — absolutely overlaid on the Sig card in .sea-pos-core
.sea-pos-center { position: relative; } .sea-pos-core { position: relative; }
.sea-pos-cover, .sea-pos-cover,
.sea-pos-cross { .sea-pos-cross {

10
src/static_src/tests/SeaDealSpec.js
View File

@@ -21,13 +21,13 @@ describe("SeaDeal", () => {
<!-- Cross grid (simplified) --> <!-- Cross grid (simplified) -->
<div class="sea-cross"> <div class="sea-cross">
<div class="sea-cross-cell sea-pos-crown"> <div class="sea-crucifix-cell sea-pos-crown">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-past"> <div class="sea-crucifix-cell sea-pos-leave">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-center"> <div class="sea-crucifix-cell sea-pos-core">
<div class="sea-sig-card"></div> <div class="sea-sig-card"></div>
<div class="sea-pos-cover"> <div class="sea-pos-cover">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
@@ -36,10 +36,10 @@ describe("SeaDeal", () => {
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
</div> </div>
<div class="sea-cross-cell sea-pos-future"> <div class="sea-crucifix-cell sea-pos-loom">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
<div class="sea-cross-cell sea-pos-root"> <div class="sea-crucifix-cell sea-pos-lay">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
</div> </div>

14
src/templates/apps/gameboard/_partials/_sea_overlay.html
View File

@@ -22,15 +22,15 @@
<div class="sea-cards-col"> <div class="sea-cards-col">
<div class="sea-cross"> <div class="sea-cross">
{# Crown — CC pos 3 / EV pos 5 #} {# Crown — CC pos 3 / EV pos 5 #}
<div class="sea-cross-cell sea-pos-crown"> <div class="sea-crucifix-cell sea-pos-crown">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
{# Beneath (past) — CC pos 4 / EV pos 3 #} {# Beneath (past) — CC pos 4 / EV pos 3 #}
<div class="sea-cross-cell sea-pos-past"> <div class="sea-crucifix-cell sea-pos-leave">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
{# Center — Significator (always placed) + Cover + Cross overlaid #} {# Center — Significator (always placed) + Cover + Cross overlaid #}
<div class="sea-cross-cell sea-pos-center"> <div class="sea-crucifix-cell sea-pos-core">
<div class="sig-stage-card sea-sig-card" style="--sig-card-w: 4rem"> <div class="sig-stage-card sea-sig-card" style="--sig-card-w: 4rem">
{% if my_tray_sig %} {% if my_tray_sig %}
<span class="fan-corner-rank">{{ my_tray_sig.corner_rank }}</span> <span class="fan-corner-rank">{{ my_tray_sig.corner_rank }}</span>
@@ -47,11 +47,11 @@
</div> </div>
</div> </div>
{# Before (future) — CC pos 5 / EV pos 6 #} {# Before (future) — CC pos 5 / EV pos 6 #}
<div class="sea-cross-cell sea-pos-future"> <div class="sea-crucifix-cell sea-pos-loom">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
{# Behind (root) — CC pos 6 / EV pos 4 #} {# Behind (root) — CC pos 6 / EV pos 4 #}
<div class="sea-cross-cell sea-pos-root"> <div class="sea-crucifix-cell sea-pos-lay">
<div class="sea-card-slot sea-card-slot--empty"></div> <div class="sea-card-slot sea-card-slot--empty"></div>
</div> </div>
</div> </div>
@@ -189,8 +189,8 @@
const SEA_DECK_URL = overlay.dataset.seaDeckUrl; const SEA_DECK_URL = overlay.dataset.seaDeckUrl;
const SPREAD_ORDER = { const SPREAD_ORDER = {
'waite-smith': ['.sea-pos-cover', '.sea-pos-cross', '.sea-pos-crown', '.sea-pos-root', '.sea-pos-future', '.sea-pos-past'], 'waite-smith': ['.sea-pos-cover', '.sea-pos-cross', '.sea-pos-crown', '.sea-pos-lay', '.sea-pos-loom', '.sea-pos-leave'],
'escape-velocity': ['.sea-pos-cover', '.sea-pos-cross', '.sea-pos-root', '.sea-pos-past', '.sea-pos-crown', '.sea-pos-future'], 'escape-velocity': ['.sea-pos-cover', '.sea-pos-cross', '.sea-pos-lay', '.sea-pos-leave', '.sea-pos-crown', '.sea-pos-loom'],
}; };
let levityPile = [], gravityPile = []; let levityPile = [], gravityPile = [];