2026-02-18 15:24:55 -05:00
|
|
|
import os
|
|
|
|
|
|
2026-02-22 21:50:25 -05:00
|
|
|
from django.conf import settings
|
2026-03-28 23:14:31 -04:00
|
|
|
from django.test import tag
|
2026-02-17 21:19:24 -05:00
|
|
|
from selenium import webdriver
|
|
|
|
|
from selenium.webdriver.common.by import By
|
2026-02-17 23:07:12 -05:00
|
|
|
|
2026-02-17 21:19:24 -05:00
|
|
|
from .base import FunctionalTest
|
2026-04-23 01:55:12 -04:00
|
|
|
from .post_page import PostPage
|
|
|
|
|
from .my_posts_page import MyPostsPage
|
2026-02-17 21:19:24 -05:00
|
|
|
|
|
|
|
|
|
|
|
|
|
# Helper fns
|
|
|
|
|
def quit_if_possible(browser):
|
|
|
|
|
try:
|
|
|
|
|
browser.quit()
|
|
|
|
|
except:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# Test mdls
|
|
|
|
|
class SharingTest(FunctionalTest):
|
2026-03-28 23:14:31 -04:00
|
|
|
@tag("two-browser")
|
2026-04-23 01:55:12 -04:00
|
|
|
def test_can_share_a_post_with_another_user(self):
|
2026-03-03 16:10:49 -05:00
|
|
|
self.create_pre_authenticated_session("disco@test.io")
|
2026-02-17 21:19:24 -05:00
|
|
|
disco_browser = self.browser
|
|
|
|
|
self.addCleanup(lambda: quit_if_possible(disco_browser))
|
|
|
|
|
|
2026-02-18 15:24:55 -05:00
|
|
|
options = webdriver.FirefoxOptions()
|
|
|
|
|
if os.environ.get("HEADLESS"):
|
|
|
|
|
options.add_argument("--headless")
|
|
|
|
|
ali_browser = webdriver.Firefox(options=options)
|
2026-02-17 21:19:24 -05:00
|
|
|
self.addCleanup(lambda: quit_if_possible(ali_browser))
|
|
|
|
|
self.browser = ali_browser
|
2026-03-03 16:10:49 -05:00
|
|
|
self.create_pre_authenticated_session("alice@test.io")
|
2026-02-17 21:19:24 -05:00
|
|
|
|
|
|
|
|
self.browser = disco_browser
|
2026-04-23 01:55:12 -04:00
|
|
|
self.browser.get(self.live_server_url + '/billboard/')
|
|
|
|
|
post_page = PostPage(self).add_post_line("Send help")
|
2026-02-17 21:19:24 -05:00
|
|
|
|
2026-04-23 01:55:12 -04:00
|
|
|
share_box = post_page.get_share_box()
|
2026-02-17 21:19:24 -05:00
|
|
|
self.assertEqual(
|
|
|
|
|
share_box.get_attribute("placeholder"),
|
buds Phase 2: top-3 username|email autocomplete on #id_recipient (post share + my_buds add); implicit symmetric auto-add on share_post (sharer ↔ recipient buds graph); recipient field accepts username OR email — TDD
- billboard.views.search_buds(GET /billboard/buds/search?q=...) — top-3 prefix match against request.user.buds via Q(username__istartswith) | Q(email__istartswith). Returns {buds: [{id, username, email}]}. Privacy: only the user's own buds are searched, no leak of strangers.
- _resolve_recipient(raw) helper resolves a free-form recipient (email if "@" present, else username, both case-insensitive). Wired into add_bud + share_post so #id_recipient accepts either form.
- share_post implicit auto-add (per-spec): when recipient is registered + first-time-shared, both directions of buds M2M get the link — request.user.buds.add(recipient) AND recipient.buds.add(request.user). Idempotent, no auto-add on reshare/self/unregistered.
- new bud-autocomplete.js shared module (apps/billboard/static/apps/billboard/) — bindBudAutocomplete(input, suggestionsEl, {searchUrl}). Mirrors sky.html birth-place picker: 250ms debounced fetch from MIN_CHARS=1, click-to-fill, Escape closes, click-outside closes, late-response drop. e.stopPropagation on suggestion-click so the bud-panel's outside-click handler doesn't fire and clear the input.
- SCSS .bud-suggestions / .bud-suggestion-item mirrors .sky-suggestions but position:fixed bottom:4rem (aligned above the bud panel, with overflow:hidden on the panel forcing the dropdown to live as a sibling rather than a child). Landscape breakpoints clear the navbar/footer 4rem sidebars, 8rem at min-width 1800px.
- both _bud_panel.html (post share) + _bud_add_panel.html (my_buds add) get the suggestions div sibling + script tags. Each panel's existing document click-outside handler now skips the suggestions container so a click inside doesn't close+clear. type="email" → type="text" since usernames are accepted; placeholder "friend@example.com or username".
- new test classes in test_buds.py: SearchBudsViewTest (6 — prefix match, cap-3, email prefix, non-bud leakproof, empty-q, anon redirect) + SharePostImplicitAutoAddTest (4 — sharer.buds += recipient, recipient.buds += sharer, username-typed share, unregistered no-add) + AddBudViewTest.test_add_resolves_username_too. test_my_buds.py FT adds test_autocomplete_suggests_buds_by_username_prefix. test_sharing.py placeholder assertion updated to "friend@example.com or username".
- 852 ITs (+11) + 5 my_buds FTs green.
Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 23:34:35 -04:00
|
|
|
"friend@example.com or username",
|
2026-02-17 21:19:24 -05:00
|
|
|
)
|
2026-02-17 23:07:12 -05:00
|
|
|
|
2026-04-23 01:55:12 -04:00
|
|
|
post_page.share_post_with("alice@test.io")
|
2026-02-17 23:27:54 -05:00
|
|
|
|
|
|
|
|
self.browser = ali_browser
|
2026-04-23 01:55:12 -04:00
|
|
|
MyPostsPage(self).go_to_my_posts_page("alice@test.io")
|
2026-02-17 23:27:54 -05:00
|
|
|
|
|
|
|
|
self.browser.find_element(By.LINK_TEXT, "Send help").click()
|
|
|
|
|
|
|
|
|
|
self.wait_for(
|
2026-04-23 01:55:12 -04:00
|
|
|
lambda: self.assertEqual(post_page.get_post_owner(), "disco@test.io")
|
2026-02-17 23:27:54 -05:00
|
|
|
)
|
|
|
|
|
|
2026-04-23 01:55:12 -04:00
|
|
|
post_page.add_post_line("At your command, Disco King")
|
2026-02-17 23:27:54 -05:00
|
|
|
|
|
|
|
|
self.browser = disco_browser
|
|
|
|
|
self.browser.refresh()
|
brief sprint C3.b+c+d+e: share-post Line+Brief async, magic-link / invalid-link banners use Brief styling, .alert-* retired — TDD
Closes the C3 brief sprint. Three event sources (note unlock, share invite, login messages) now route through the Brief slide-down, & the legacy .alert-success/.alert-warning rendering in base.html is retired.
C3.b — share-post async Line + Brief:
- billboard.share_post detects Accept: application/json. JSON path appends a Line (text="Shared with X at <isoformat>", isoformat carries microseconds so two rapid shares of the same email don't collide on Line.unique_together(post,text)), spawns a Brief(kind=SHARE_INVITE) for the sharer, and returns {brief: brief.to_banner_dict() | None, line_text, recipient_display}. Sharer-shares-with-themselves stays a silent no-op (response carries brief: null). Legacy form-submit path preserved for non-AJAX (still redirects + flashes the privacy-safe message — kept for older FTs / no-JS fallback).
- billboard.Brief.to_banner_dict() (moved from dashboard.views helper to a model method) shapes the JSON the banner JS consumes.
- post.html: share form intercepted by JS — fetches POST w. Accept:application/json, then appends `data.line_text` as the next row in #id_post_table, calls Brief.showBanner(data.brief), and (when registered) appends a fresh `<span class="post-recipient">` to the new #id_post_recipients box. No page reload — the alert-success flash is gone.
- 10 new ITs (SharePostAsyncTest + SharePostLegacyRedirectTest) cover the JSON path, line append, brief creation w. SHARE_INVITE kind, registered/unregistered recipient behaviour, sharer-self skip, line dedupe via timestamp, and that the legacy form-submit redirect path still works.
- functional_tests.test_sharing line numbering updated: the share now records its own Line so the alice-reply lands at row 3 instead of 2.
C3.c+d — magic-link confirmation + invalid-link error use Brief banner styling:
- base.html's {% if messages %} block stops rendering .alert-success/.alert-warning divs. Instead each message renders as a transient Brief-styled banner: <div class="note-banner note-banner--message note-banner--{{level_tag}}"> with .note-banner__body / __description carrying the message text and a .btn-cancel NVM that removes the banner via inline onclick. No DB Brief row; no FYI; no square. Same Gaussian-glass look as note-unlock + share-invite Briefs.
- _note.scss adds the note-banner--message variant (full-opacity description) + note-banner--error/--warning border-color override (priRd 0.6) so the invalid-link banner reads as red/abandon.
C3.e — .alert-success/.alert-warning retired in markup; the SCSS class blocks aren't referenced anywhere else in templates so they sit dormant (left in place — base form styling keeps .form-control etc. working; no need to ripple into _base.scss).
Banner JS (note.js / Brief module) was untouched in C3.b+c+d — the Brief.showBanner contract from C3.a already handles all three kinds (NOTE_UNLOCK / USER_POST / SHARE_INVITE) by reading kind off the brief; the message-banner path doesn't go through showBanner because there's no Brief row.
Tests: 218 dashboard+billboard+api ITs + 322 lyric+dashboard+billboard ITs + 2 sharing FTs + 9 my_notes FTs + 1 Jasmine FT all green. Existing lyric.test_views login message-text assertions unchanged (they pull from messages framework — not the rendered HTML — so the markup swap doesn't affect them).
Code architected by Disco DeDisco <discodedisco@outlook.com>
Git commit message Co-Authored-By:
Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-08 18:15:43 -04:00
|
|
|
# Line numbering: 1) "Send help" 2) "Shared with alice@test.io …"
|
|
|
|
|
# (auto-appended by share_post in C3.b) 3) Alice's reply.
|
|
|
|
|
post_page.wait_for_row_in_post_table("At your command, Disco King", 3)
|
2026-02-22 21:50:25 -05:00
|
|
|
|
2026-04-23 01:55:12 -04:00
|
|
|
class PostAccessTest(FunctionalTest):
|
|
|
|
|
def test_stranger_cannot_access_owned_post(self):
|
2026-03-03 16:10:49 -05:00
|
|
|
self.create_pre_authenticated_session("disco@test.io")
|
2026-04-23 01:55:12 -04:00
|
|
|
self.browser.get(self.live_server_url + '/billboard/')
|
|
|
|
|
PostPage(self).add_post_line("private eye")
|
|
|
|
|
post_url = self.browser.current_url
|
2026-02-22 21:50:25 -05:00
|
|
|
|
|
|
|
|
self.browser.delete_cookie(settings.SESSION_COOKIE_NAME)
|
2026-04-23 01:55:12 -04:00
|
|
|
self.browser.get(post_url)
|
2026-02-22 21:50:25 -05:00
|
|
|
|
2026-04-23 01:55:12 -04:00
|
|
|
self.assertNotEqual(self.browser.current_url, post_url)
|